Open
Conversation
DedSec256
suggested changes
Mar 4, 2022
DedSec256
left a comment
DedSec256
left a comment
There was a problem hiding this comment.
Есть небольшие замечания, после которых задачи можно зачесть
hw1/hw1/Program.fs
Outdated
Comment on lines
47
to
48
| if list = [] then | ||
| raise(ArgumentException("")) |
There was a problem hiding this comment.
учитывая проверки двумя строками ниже, этот кусок кода избыточен (:
hw1/hw1/Program.fs
Outdated
Comment on lines
51
to
56
| if list = [] then | ||
| raise(ArgumentException("Нет такого элемента в списке")) | ||
| if List.head list = number then | ||
| i | ||
| else | ||
| findElement (List.tail list) number (i + 1) |
There was a problem hiding this comment.
тут лучше использопать паттерн-матчинг для списков
hw1/hw1/Program.fs
Outdated
Comment on lines
28
to
29
| if List.length list = 0 then | ||
| [] |
There was a problem hiding this comment.
Во-первых, для определения длины выполняется полный проход по списку.
Во-вторых, этот код избыточен, ибо такая же проверка выполняется двумя строками ниже.
hw1/hw1/Program.fs
Outdated
|
|
||
| let fibonacci n = | ||
| if n < 0 then | ||
| raise (ArgumentException"n должно быть неотрицательным") |
There was a problem hiding this comment.
Кто украл пробел?
Suggested change
| raise (ArgumentException"n должно быть неотрицательным") | |
| raise (ArgumentException "n должно быть неотрицательным") |
DedSec256
suggested changes
Mar 7, 2022
hw1/hw1/Program.fs
Outdated
| if list = [] then | ||
| listNew | ||
| else | ||
| reverseListMaker (List.tail list) ((List.head list) :: listNew) |
There was a problem hiding this comment.
тут лучше использопать паттерн-матчинг для списков
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.