Open
Conversation
DedSec256
suggested changes
Mar 19, 2022
hw2/hw2/Program.fs
Outdated
Comment on lines
56
to
57
| | h :: tail when element % h = 0 -> false | ||
| | h :: tail when element % h <> 0 -> testOnPrime element tail |
There was a problem hiding this comment.
можно было бы записать как-то так
Suggested change
| | h :: tail when element % h = 0 -> false | |
| | h :: tail when element % h <> 0 -> testOnPrime element tail | |
| | h :: tail -> | |
| if element % h = 0 then false else testOnPrime element tail |
но это не принципиально
|
|
||
| [<Test>] | ||
| let countEvenNumbersCheck () = | ||
| let check x = |
There was a problem hiding this comment.
было бы так же неплохо проверить на корректность одну из функций. А то окажется, что все функции эквивалентны, но некорректны.
hw2/hw2.Test/FunctionsTest.fs
Outdated
|
|
||
| [<Test>] | ||
| let funcToTreeTest () = | ||
| let tree1 = Tree.Tree(2, Tree.Tip(4), Tree.Tip(6)) |
There was a problem hiding this comment.
В тестовом дереве не хватает случаев, когда левое и правое поддерево непустые.
hw2/hw2.Test/FunctionsTest.fs
Outdated
|
|
||
| [<Test>] | ||
| let countTreeTest () = | ||
| let tree1 = TreeArithmetic.Node(Multiplication, Leaf 2, Node(Summation, Leaf 1, Leaf 1)) |
There was a problem hiding this comment.
остальные функции тоже было бы неплохо протестировать.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.