generated from MinBZK/python-project-template
-
Notifications
You must be signed in to change notification settings - Fork 0
Implement GUI roles #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Implement GUI roles #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54fe01d
to
a584890
Compare
c97c930
to
72e5238
Compare
72e5238
to
0835a02
Compare
ChristopherSpelt
previously approved these changes
Apr 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Alleen wel nog een pre commit failure
cc59cb2
to
830d357
Compare
f49bc75
to
668aeaa
Compare
96bb062
to
20ac58d
Compare
20ac58d
to
1e48454
Compare
rubenrouwhof
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the authorization system. Authorization is widely integrated in the code, so a lot of files had to be updated.
Also introduced is the ServicesProvider, which can be used to get the various Services and Repositories. This change avoids having to pass many variables, services and repositories, which are used throughout a flow.
Resolves #419
Checklist
Please check all the boxes that apply to this pull request using "x":