Skip to content

Implement GUI roles #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

Conversation

uittenbroekrobbert
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert commented Mar 27, 2025

Description

Implement the authorization system. Authorization is widely integrated in the code, so a lot of files had to be updated.

Also introduced is the ServicesProvider, which can be used to get the various Services and Repositories. This change avoids having to pass many variables, services and repositories, which are used throughout a flow.

Resolves #419

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert linked an issue Mar 27, 2025 that may be closed by this pull request
@uittenbroekrobbert uittenbroekrobbert marked this pull request as ready for review April 2, 2025 11:19
@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner April 2, 2025 11:19
@uittenbroekrobbert uittenbroekrobbert force-pushed the 419-front-end-permissions-and-roles branch from 54fe01d to a584890 Compare April 2, 2025 11:19
@uittenbroekrobbert uittenbroekrobbert force-pushed the 419-front-end-permissions-and-roles branch 9 times, most recently from c97c930 to 72e5238 Compare April 14, 2025 08:24
@uittenbroekrobbert uittenbroekrobbert force-pushed the 419-front-end-permissions-and-roles branch from 72e5238 to 0835a02 Compare April 18, 2025 08:03
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Alleen wel nog een pre commit failure

@uittenbroekrobbert uittenbroekrobbert force-pushed the 419-front-end-permissions-and-roles branch from cc59cb2 to 830d357 Compare May 8, 2025 11:38
@uittenbroekrobbert uittenbroekrobbert force-pushed the 419-front-end-permissions-and-roles branch 6 times, most recently from f49bc75 to 668aeaa Compare May 28, 2025 06:57
@uittenbroekrobbert uittenbroekrobbert force-pushed the 419-front-end-permissions-and-roles branch 4 times, most recently from 96bb062 to 20ac58d Compare May 30, 2025 13:10
@uittenbroekrobbert uittenbroekrobbert force-pushed the 419-front-end-permissions-and-roles branch from 20ac58d to 1e48454 Compare June 4, 2025 10:34
@rubenrouwhof rubenrouwhof self-requested a review June 4, 2025 10:39
Copy link
Contributor

@rubenrouwhof rubenrouwhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

sonarqubecloud bot commented Jun 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
89.7% Coverage on New Code (required ≥ 95%)

See analysis details on SonarQube Cloud

@uittenbroekrobbert uittenbroekrobbert merged commit bcef32e into main Jun 4, 2025
13 of 15 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the 419-front-end-permissions-and-roles branch June 4, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front-end permissions and roles
3 participants