Add template setup #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anneschuth
reviewed
Apr 19, 2024
anneschuth
reviewed
Apr 22, 2024
anneschuth
reviewed
Apr 22, 2024
berrydenhartog
force-pushed
the
feature/template
branch
from
5556fd0 to
f0b55df
Compare
There was a problem hiding this comment.
Do we want to add the cspell spelling to the pre-commit template? as defined here:
https://github.com/MinBZK/ai-validation/blob/main/.pre-commit-config.yaml
uittenbroekrobbert
previously approved these changes
Apr 22, 2024
There was a problem hiding this comment.
LGTM and I think it's an extremely complete setup. Kudos @berrydenhartog!
ChristopherSpelt
previously approved these changes
Apr 22, 2024
berrydenhartog
dismissed stale reviews from ChristopherSpelt and uittenbroekrobbert
via
415c36a
berrydenhartog
force-pushed
the
feature/template
branch
from
f0b55df to
415c36a
Compare
berrydenhartog
requested review from
anneschuth and
ChristopherSpelt
and removed request for
anneschuth and
ChristopherSpelt
anneschuth
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR to create a basic python project template