Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to reduce slot time in lucy test #13856

Closed
wants to merge 11 commits into from

Conversation

deepthiskumar
Copy link
Member

@deepthiskumar deepthiskumar commented Aug 11, 2023

Issues fixed in the following PRs were seen when debugging shorter slot time. These changes are all included in this PR

  1. Wait for node initialization log event after restarts in lucy #13852
  2. Fix for create-diff not including transactions #13853
  3. fix flaking insufficient replace fee check in zkApps test #13855

Using a fairly clean CI run on berkeley with current slot time for comparison- https://buildkite.com/o-1-labs-2/mina-o-1-labs/builds/29782#_

Test slot time Time for successful runs % improvement Flakes
1. Chain reliability test 45s ~17mins 26% Still seeing some flakes, needs investigation to check if they are test related
2. Peers reliability test 45s ~20mins 28% Still seeing some flakes, needs investigation to check if they are test related
3. Gossip consistency 45s ~12mins -10% (not sure why the time increased) Haven’t seen many flakes
4. Medium Bootstrap 45s ~33mins 13% Still seeing some flakes, needs investigation to check if they are test related
5. Verification key update 45s ~13mins 32% Haven’t seen any flakes related to the test itself
6. zkApp timing 45s ~21mins 26% Haven’t seen any flakes related to the test itself
7. Payments test 60s ~21mins 46% Has run successfully many times. Occasionally times out waiting for ledger proofs. Next steps: Increase padded payments, check if there’s any change in block production due to slow slot time that causes this, increase wait time
8. zkApps test 90s ~30mins 19% Similar to payments test, zkApps test times out waiting for ledger proofs. Next steps: Same as payments test
9. zkApps nonce test 90s ~36mins 3% Haven’t seen any flakes related to the test itself

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@deepthiskumar
Copy link
Member Author

!ci-build-me

… almost at the same time causing flakes. nodes_to_synchronize implemented correctly should cover this
@deepthiskumar
Copy link
Member Author

!ci-build-me

@mrmr1993
Copy link
Member

mrmr1993 commented Jan 12, 2024

Cross-referenced in tracking issue #13845. Closing this experimental PR.

@mrmr1993 mrmr1993 closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants