Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snarkyjs and snarkyjs-bindings and proof-systems to develop #14170

Merged
merged 15 commits into from
Oct 5, 2023

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Sep 21, 2023

A breaking change has been merged into develop, and bindings and stubs have not been merged/changed accordingly.

Set snarkyjs to develop, including snarkyjs-bindings.
Checking out snarkyjs to develop, same for bindings, running npm run bindings in snarkyjs and fix the lint of bindings.js.

Explain your changes:

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@dannywillems dannywillems requested a review from a team as a code owner September 21, 2023 09:47
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems changed the title Bump up snarkyjs after artefacts generation Update snarkyjs and snarkyjs-bindings to develop Sep 21, 2023
@dannywillems dannywillems requested a review from a team as a code owner September 22, 2023 13:34
@dannywillems dannywillems force-pushed the dannywillems/bump-up-bindings-20230920 branch from 99d4d7b to 152674b Compare September 22, 2023 13:37
@dannywillems dannywillems changed the title Update snarkyjs and snarkyjs-bindings to develop Update snarkyjs and snarkyjs-bindings and proof-systems to develop Sep 22, 2023
@dannywillems dannywillems force-pushed the dannywillems/bump-up-bindings-20230920 branch from 125bcdb to dcb7d9c Compare September 22, 2023 16:15
@mrmr1993
Copy link
Member

mrmr1993 commented Oct 4, 2023

!ci-build-me

@dannywillems dannywillems merged commit becddaa into develop Oct 5, 2023
1 of 2 checks passed
@dannywillems dannywillems deleted the dannywillems/bump-up-bindings-20230920 branch October 5, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants