-
Notifications
You must be signed in to change notification settings - Fork 578
add alerts for stuck at catchup and bootstrap #14204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ghost-not-in-the-shell
merged 10 commits into
berkeley
from
alert/catchup-and-bootstrap-got-stuck
Oct 18, 2023
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
284cced
add alerts for stuck at catchup and bootstrap
da74bb2
Merge branch 'berkeley' into alert/catchup-and-bootstrap-got-stuck
ghost-not-in-the-shell 051d117
Merge branch 'berkeley' into alert/catchup-and-bootstrap-got-stuck
ghost-not-in-the-shell f87075f
Merge branch 'berkeley' into alert/catchup-and-bootstrap-got-stuck
ghost-not-in-the-shell 9e9e1eb
Merge branch 'berkeley' into alert/catchup-and-bootstrap-got-stuck
ghost-not-in-the-shell d15044d
Merge branch 'berkeley' into alert/catchup-and-bootstrap-got-stuck
ghost-not-in-the-shell fd43d8c
Merge branch 'berkeley' into alert/catchup-and-bootstrap-got-stuck
ghost-not-in-the-shell 17c65d0
Merge branch 'berkeley' into alert/catchup-and-bootstrap-got-stuck
ghost-not-in-the-shell a64807a
Merge branch 'berkeley' into alert/catchup-and-bootstrap-got-stuck
ghost-not-in-the-shell ebecbcb
Merge branch 'berkeley' into alert/catchup-and-bootstrap-got-stuck
ghost-not-in-the-shell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
increase
only computes against the latest monotonic sequence of samples within the specified range, this alert will not trigger if a node is repeatedly crashing and restarting into bootstrap. That's fine so long as we have another alert that is capturing that. Do you know of a alert that would trigger if the nodes are repeatedly restarting into bootstrap?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. There's no such alert for now. Once the daemon is restarted, I believe it would start with a new node/instance in gcloud (this is just my experience with grafana charts). So if we want to capture the data during multiple restart we need to use the label
app
to capture a specific pod. For now I don't know a good way to automatically collect the data from different instances of one pod together. I wish there is agroup by
in prometheus query language. I would do a research on that.