Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop] Updating Rust versions of proof-systems and kimchi_bindings/stubs to 1.72 #14225

Merged
merged 14 commits into from
Oct 6, 2023
Merged

[develop] Updating Rust versions of proof-systems and kimchi_bindings/stubs to 1.72 #14225

merged 14 commits into from
Oct 6, 2023

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Sep 27, 2023 •
edited
Loading

TODO:

  • wasm-pack has been updated to 0.12.1 in eca4f72, but the build image hasn't been updated.
    Explain your changes:

Fix #14249, #14254

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@dannywillems dannywillems requested a review from a team as a code owner September 27, 2023 15:42
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems changed the title Updating Rust versions of proof-systems and kimchi_bindings/stubs to 1.72 [develop] Updating Rust versions of proof-systems and kimchi_bindings/stubs to 1.72 Sep 27, 2023
@rbonichon rbonichon mentioned this pull request Sep 27, 2023
Merged
@rbonichon rbonichon requested a review from a team as a code owner September 27, 2023 19:48
@rbonichon rbonichon force-pushed the develop-20230927-temporary branch from 49ca2ac to f5984f7 Compare September 27, 2023 20:16
@dannywillems
Copy link
Member Author

!ci-build-me

@rbonichon rbonichon force-pushed the develop-20230927-temporary branch from f5984f7 to e06c6ea Compare September 28, 2023 05:10
@rbonichon rbonichon force-pushed the develop-20230927-temporary branch from e06c6ea to 39e6874 Compare September 28, 2023 08:00
@rbonichon
Copy link
Contributor

!ci-build-me

@dannywillems
Copy link
Member Author 



warning: some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
--


note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest

In the warnings.

@dannywillems dannywillems force-pushed the develop-20230927-temporary branch from 39e6874 to 7061aff Compare October 3, 2023 13:06
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems requested a review from a team as a code owner October 3, 2023 13:32
@dannywillems
Copy link
Member Author

!ci-build-me

1 similar comment
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems force-pushed the develop-20230927-temporary branch from 68633e2 to 56010e0 Compare October 3, 2023 15:24
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems
Copy link
Member Author

dannywillems commented Oct 3, 2023 •
edited
Loading

@rbonichon why is there duplicated Rust versions in bf5308c?

@dannywillems
Copy link
Member Author

!ci-build-me

1 similar comment
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems
Copy link
Member Author

Should be good to go!!
@rbonichon can you check the Nix config please? The hashes for wasm-bindgen should be the one for 0.2.84.

@dannywillems
Copy link
Member Author

!ci-build-me

@rbonichon rbonichon force-pushed the develop-20230927-temporary branch from 3858cd3 to 33652eb Compare October 3, 2023 19:46
@dannywillems
Copy link
Member Author

!ci-build-me

rbonichon
rbonichon approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@rbonichon rbonichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's move forward!

buildkite/src/Constants/ContainerImages.dhall Show resolved Hide resolved
src/lib/crypto/kimchi_bindings/stubs/src/arkworks/bigint_256.rs Show resolved Hide resolved
@dannywillems
Copy link
Member Author

!ci-build-me

stevenplatt
stevenplatt approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@stevenplatt stevenplatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toolchain container update looks good. Approved.

@dannywillems dannywillems merged commit 491837b into develop Oct 6, 2023
1 of 2 checks passed
@dannywillems dannywillems deleted the develop-20230927-temporary branch October 6, 2023 15:25
@dannywillems dannywillems mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenplatt stevenplatt stevenplatt approved these changes

@mitschabaude mitschabaude mitschabaude approved these changes

@rbonichon rbonichon rbonichon approved these changes

Assignees

@rbonichon rbonichon

@dannywillems dannywillems

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating wasm-pack to 0.12.1
4 participants
@dannywillems @rbonichon @mitschabaude @stevenplatt