Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for ppx_version #14261

Merged
merged 13 commits into from
Oct 5, 2023
Merged

Add docs for ppx_version #14261

merged 13 commits into from
Oct 5, 2023

Conversation

psteckler
Copy link
Member

@psteckler psteckler commented Oct 3, 2023 •
edited
Loading

Add to and update the internal documentation for ppx_version.

Also, removing the Printing module from Versioned_type, which was used for the old version linter. The printed representations of all versioned types are still available in the output of internal dump-type-shapes.

Remove vendored_dirs from the dune file, which prevented ppx_version linting warnings from appearing. Running make build does not build the tests, because no code depends on that library. Verified that the tests succeed locally (we're not running them in CI). Added a README file for the tests.

@psteckler psteckler requested a review from a team as a code owner October 3, 2023 23:23
@psteckler
Copy link
Member Author

!ci-build-me

psteckler and others added 4 commits October 4, 2023 08:36
@psteckler @barriebyron
Update src/lib/ppx_version/versioned_module.ml
5df1d1c 
Co-authored-by: Barrie Byron <barrie@o1labs.org>
@psteckler @barriebyron
Update src/lib/ppx_version/versioned_module.ml
93d9eec 
Co-authored-by: Barrie Byron <barrie@o1labs.org>
@psteckler @barriebyron
Update src/lib/ppx_version/versioned_module.ml
4215cbb 
Co-authored-by: Barrie Byron <barrie@o1labs.org>
@psteckler @barriebyron
Update src/lib/ppx_version/versioned_module.ml
113e0cc 
Co-authored-by: Barrie Byron <barrie@o1labs.org>
@barriebyron barriebyron self-requested a review October 4, 2023 15:52
@psteckler
Copy link
Member Author

!ci-build-me

@psteckler
Copy link
Member Author

!ci-build-me

@psteckler psteckler requested review from a team as code owners October 5, 2023 20:12
@psteckler
Copy link
Member Author

!ci-build-me

@psteckler
Copy link
Member Author

!ci-build-me

@psteckler
Copy link
Member Author

!ci-build-me

@psteckler psteckler merged commit 62a38ff into develop Oct 5, 2023
1 of 2 checks passed
@psteckler psteckler deleted the fix/update-ppx-version-docs branch October 5, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinMinkov MartinMinkov MartinMinkov approved these changes

@ghost-not-in-the-shell ghost-not-in-the-shell ghost-not-in-the-shell approved these changes

@barriebyron barriebyron Awaiting requested review from barriebyron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psteckler @ghost-not-in-the-shell @MartinMinkov @barriebyron