Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename previous_global_slot to genesis_slot in compatible #14263

Closed

Conversation

Sventimir
Copy link
Contributor

Explain your changes:

  • For the genesis ledger export (as described in [RFC] Genesis ledger export #14213) to succeed, we need runtime configs of the Mainnet and berkeley to be as compatible as possible. Thus porting 2be03bf to compatible to avoid conflicts.

Explain how you tested your changes:

  • Run the node, exported the fork ledger.
  • Run the CI.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@Sventimir
Copy link
Contributor Author

!ci-build-me

@Sventimir
Copy link
Contributor Author

Make it a draft until #14271 lands and solves the conflicts with berkeley.

@Sventimir Sventimir marked this pull request as ready for review November 28, 2023 08:30
@Sventimir
Copy link
Contributor Author

!ci-build-me

1 similar comment
@Sventimir
Copy link
Contributor Author

!ci-build-me

@mrmr1993
Copy link
Member

mrmr1993 commented Mar 4, 2024

This PR is now stale, and the issue was handled a different way. The test runs with the other method have been successful, and compatible will be retired soon, so I'm going to close this.

@mrmr1993 mrmr1993 closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants