Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower the version linter
max_depth
to 9 (was 12). That's the depth of the type shapes, as S-expressions, used when comparing them across branches. The type shapes are truncated to that depth, so that differences in contained types are elided, avoiding false positives.Tested by running the script locally with edited type shape files. Changes tried:
A depth of 10 gave an error for the last case. Backing off to 9 removed the generated error.
There may still be occasional false positives. For example, a contained type might be simpler than a record, such as a built-in type or variant, for instance. Those should be infrequent, and easy enough to spot, because the change to the contained type will also generate an error.
In fact, the truncation code wasn't working, because the type shape was not converted to an S-expression. Fixed here.
Added the
--no-clobber
option towget
, so that the type shape file is not downloaded if it exists (which it did with repeated local testing).Closes #14232.