Fix flakiness insufficient replace fee #14387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
Fix flakiness of the zkapps test, the timeout is added to avoid a race condition between ledger update and transaction pool update. The fix is simply to wait for a block to be produced and then wait for another 30 secs before we send out the zkApps. The reason for that is to make sure that update to the ledger and the transaction pool to be 100% synced before we sending out new zkApps. We wait 30s after a block is being produced because we want to avoid the situation that the previous "update states" zkApps being accidentally included a block before we send out the "insufficient replace fee" zkApps. A more detailed analysis of this can be find in #13854
Explain how you tested your changes:
*
Checklist: