-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First-pass ledger hashes in replayer checkpoint files #14390
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1585c18
First-pass ledger hashes in replayer checkpoint files
c2ee02f
Save last snarked ledger hash
302e296
Merge branch 'berkeley' into feature/ledger-hashes-in-checkpoint
psteckler 0777406
Merge branch 'berkeley' into feature/ledger-hashes-in-checkpoint
psteckler 26687d5
Merge branch 'berkeley' into feature/ledger-hashes-in-checkpoint
psteckler 8c9026e
Merge branch 'berkeley' into feature/ledger-hashes-in-checkpoint
psteckler 359c222
Merge branch 'berkeley' into feature/ledger-hashes-in-checkpoint
deepthiskumar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an
O(n)
operation, right?If yes, I wonder why the hash set is used instead of simple list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Probably when I started on it, I thought we could do lookups on the
hash
alone.The hash set is a mutable data structure, with the list we'd need to use a mutable reference. Not sure which is better.