Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache prover keys #14396

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Cache prover keys #14396

merged 9 commits into from
Oct 31, 2023

Conversation

mitschabaude
Copy link
Contributor

@mitschabaude mitschabaude commented Oct 19, 2023 •
edited
Loading

  • exposes Pickles.Cache along with types for the storables defined there
  • adds an optional storables argument to Pickles.compile to override the existing storables
  • implements Pickles.Verification_key.of_yojson to use as the serialization format

@mitschabaude mitschabaude mentioned this pull request Oct 19, 2023
Merged
@mitschabaude mitschabaude marked this pull request as ready for review October 23, 2023 15:10
@mitschabaude mitschabaude requested a review from a team as a code owner October 23, 2023 15:10
mrmr1993
mrmr1993 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see nit

src/lib/pickles/cache.ml Outdated Show resolved Hide resolved
src/lib/pickles/cache.mli Outdated Show resolved Hide resolved
src/lib/pickles/verification_key.ml
@@ -100,6 +100,11 @@ module Verifier_index_json = struct
verifier_index_to_yojson fp
(fun _ -> `Null)
(polycomm_to_yojson (or_infinity_to_yojson fq))

let of_yojson fp fq =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@mitschabaude mitschabaude requested a review from a team as a code owner October 30, 2023 15:49
@mitschabaude
Copy link
Contributor Author

!ci-build-me

@mitschabaude mitschabaude mentioned this pull request Oct 30, 2023
Merged
@mitschabaude mitschabaude merged commit fbd97fe into o1js-main Oct 31, 2023
1 of 2 checks passed
@mitschabaude mitschabaude deleted the feature/pickles-js-caching branch October 31, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinMinkov MartinMinkov MartinMinkov approved these changes

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitschabaude @mrmr1993 @MartinMinkov