Fix/itn mangled errors #14397
Merged
Fix/itn mangled errors #14397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
mrmr1993
approved these changes
Oct 19, 2023
|
!ci-nightly-me |
|
!approved-for-mainnet |
|
all protocol tests passed- https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/630#_ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14383.
Closes #14366.
This PR fixes issues observed in ITN where the actual error messages are being mangled. The first fix is to O1trace, and allows O1trace to correctly propagate exceptions thrown during the first cycle of a traced async thread. The second fix is to reraise exceptions coming from inside of Mina_net2, so that we get the originating backtrace of the exception, rather than just the backtrace where the exception was handled.