Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create terraform module for Google Cloud Postgres deployments #14399

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

stevenplatt
Copy link
Contributor

@stevenplatt stevenplatt commented Oct 20, 2023

Explain your changes:

  • This code creates a terraform module that can be used to deploy an instance of Google Cloud postgres. The first use of this module has been to deploy a postgres instance to use as a backend for a prototype of a CI metric dashboard. To make that work reusable, the underlying terraform configurations were made abstract so that they could be used as a module within larger terraform deployments.

Explain how you tested your changes:

  • This change was test by deploying a cloud postgres instance to Google Cloud. The features of this terraform module which were tested include:
  • Assigning a label for billing purposes
  • Pulling in a user password from Google Secret Manager
  • Abstracting all configurations to variables for use in larger terraform deployments
  • Appending a randomly generate name suffix to avoid deployment conflicts
  • Printing the final IP address and user account credentials to the console for connecting to the deployed db
  • Included initial README

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@stevenplatt stevenplatt changed the title Steven ci metrics Create Google Cloud postgres terraform module Oct 20, 2023
@stevenplatt stevenplatt changed the title Create Google Cloud postgres terraform module Create terraform module for Google Cloud Postgres deployments Oct 20, 2023
@stevenplatt stevenplatt self-assigned this Oct 20, 2023
@stevenplatt stevenplatt requested a review from a team October 20, 2023 03:31
Copy link
Collaborator

@SanabriaRusso SanabriaRusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice step towards a (bright) templates-based platforms future

@stevenplatt stevenplatt merged commit d5ae586 into develop Oct 24, 2023
1 of 2 checks passed
@stevenplatt stevenplatt deleted the steven-ci-metrics branch October 24, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants