Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset feature flags before assertion #14402

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

mrmr1993
Copy link
Member

This PR changes the handling of feature_flags in Pickles for wrap circuits. Previously, we were propagating the flags from the step circuit, which could cause a sanity-check assertion to fail when we convert the 'full' set of values back to the 'wrap only' set of values. This PR fixes that by always resetting the flags before entering that conversion.

This PR does not change any circuits, protocol constants, etc.; the behavior is only changed when those offending flags are set. As such, this can be deployed to snark workers as a compatible bugfix version.

Tests to follow.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 requested a review from a team as a code owner October 20, 2023 17:16
@mrmr1993 mrmr1993 changed the title [hotfix] Reset feature flags before assertion Reset feature flags before assertion Oct 20, 2023
@mrmr1993
Copy link
Member Author

!ci-build-me

Copy link
Contributor

@rbonichon rbonichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrmr1993
Copy link
Member Author

mrmr1993 commented Jan 8, 2024

!ci-build-me

@mrmr1993
Copy link
Member Author

mrmr1993 commented Jan 8, 2024

!ci-nightly-me

@mrmr1993
Copy link
Member Author

mrmr1993 commented Jan 8, 2024

!approved-for-mainnet

@mrmr1993
Copy link
Member Author

mrmr1993 commented Jan 8, 2024

Merging through versioned-type-linter; it's broken whenever the tip of rampup is a PR that didn't change the daemon code :(

@mrmr1993 mrmr1993 merged commit d8740f5 into rampup Jan 8, 2024
34 of 36 checks passed
@mrmr1993 mrmr1993 deleted the fix/wrap-circuit-features branch January 8, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants