Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pickles] Avoid recomputation of cached verification keys #14412

Merged
merged 3 commits into from
Oct 26, 2023
Merged

[Pickles] Avoid recomputation of cached verification keys #14412

merged 3 commits into from
Oct 26, 2023

Conversation

mitschabaude
Copy link
Contributor

@mitschabaude mitschabaude commented Oct 23, 2023 •
edited
Loading

Changes what Pickles.Cache returns in read_or_generate, from a keypair (prover and verifier key, Impl.Keypair.t) to a prover key (Impl.Prover_key.t, which is just a Rust prover index).

The verifier key on the Keypair.t structure was never used, but still expensively recomputed when reading prover keys from cache.

@mitschabaude mitschabaude requested review from a team as code owners October 23, 2023 15:08
@mitschabaude mitschabaude changed the base branch from develop to o1js-main October 23, 2023 15:09
@mitschabaude mitschabaude mentioned this pull request Oct 23, 2023
Merged
@mitschabaude
Copy link
Contributor Author

!ci-build-me

@mitschabaude
Copy link
Contributor Author

!ci-build-me

@mitschabaude mitschabaude merged commit 196d51b into o1js-main Oct 26, 2023
1 of 2 checks passed
@mitschabaude mitschabaude deleted the feature/avoid-cached-vk-recomputation branch October 26, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitschabaude @mrmr1993