Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Itn3 logging deployment #14423

Closed
wants to merge 5 commits into from
Closed

Itn3 logging deployment #14423

wants to merge 5 commits into from

Conversation

stevenplatt
Copy link
Contributor

@stevenplatt stevenplatt commented Oct 25, 2023

Explain your changes:

  • This PR holds the final infra code that is being used for the logging backend for the testworld-2-0 testnet. This configuration began as a docker compose that deployed 3 containers to a VM, that version of the configuration was initially created by Viable Systems (a Mina ecosystem partner), but was later asked to migrate to O(1)Labs for deployment. The version that is in this PR has additional Terraform scaffolding to allow it handle secrets that cannot live in the Docker Compose file. The Terraform structure also allows it to be connected to an external managed db for better reliability (this feature is commented out for now in the mina.tf file).
  • A README files has been included with the infra code as well, to document the intended use: automation/terraform/deployments/testworld-logging/README.md

Explain how you tested your changes:

  • This code has been tested by completing a deployment. It has been confirmed as working by using ssh to connect to the resulting VM and check that the configured Docker Compose deployment, as well as the secret values have been correctly loaded.
  • The containers that are used in the Docker Compose has been provided by @georgeee . As a secondary validation, George has also connected to the deployment to confirm the service and connections that are expected to be exposed from the Docker Compose are indeed functioning as intended.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@stevenplatt stevenplatt self-assigned this Oct 25, 2023
@stevenplatt stevenplatt added the itn3 https://docs.google.com/document/d/1ualsFs9NbgavFZj1Z4CYHf4PdRGblyz1wOl9BawT1iU label Oct 25, 2023
@stevenplatt stevenplatt requested review from a team, SanabriaRusso and georgeee October 25, 2023 01:35
Copy link
Member

@dkijania dkijania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Just nitpicking


metadata = {
startup-script = <<SCRIPT
${data.template_file.fe-config.rendered}
Copy link
Collaborator

@SanabriaRusso SanabriaRusso Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read that template_file is to be deprecated in favor of the templatefile function. I understand that maybe we are using it because of the Terraform version used in the Buildkite agents?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. I am not sure if the new format is compatible with our older version of Terraform. I would have to test for this. I will open a second zenhub item to test and move these templates, in addition to enabling the remote DB access.

@stevenplatt
Copy link
Contributor Author

!ci-build-me

@stevenplatt
Copy link
Contributor Author

Closing this as a duplicate of: 0e160f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
itn3 https://docs.google.com/document/d/1ualsFs9NbgavFZj1Z4CYHf4PdRGblyz1wOl9BawT1iU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy log-trace-collector backend + frontend
3 participants