Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] add ledger proof statement to blockchain state in GraphQL #14483

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

psteckler
Copy link
Member

Added relevant commits from #14220 to allow merge-to-develop to succeed in CI there.

Had to make some other small changes (in 8692d18) because develop had other changes.

@psteckler psteckler requested review from a team as code owners November 2, 2023 01:32
@psteckler
Copy link
Member Author

!ci-build-me

@@ -20,7 +20,7 @@ module Pending_snark_work = struct
type t =
{ work_id : int
; fee_excess : Currency.Amount.Signed.t
; supply_increase : Currency.Amount.t
; supply_change : Currency.Amount.Signed.t
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, why the renaming?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See next answer.

; supply_increase = w.supply_change.fee_magnitude
(to_signed_fee_exn fee_excess_left.sign
fee_excess_left.feeMagnitude )
; supply_change =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this renamed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In GraphQL, supplyIncrease is deprecated in favor of supplyChange.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psteckler
Copy link
Member Author

!ci-build-me

@deepthiskumar deepthiskumar merged commit 974097e into develop Nov 2, 2023
@deepthiskumar deepthiskumar deleted the feature/merge-to-develop-for-14220 branch November 2, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants