-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] add ledger proof statement to blockchain state in GraphQL #14483
Conversation
!ci-build-me |
src/lib/cli_lib/graphql_types.ml
Outdated
@@ -20,7 +20,7 @@ module Pending_snark_work = struct | |||
type t = | |||
{ work_id : int | |||
; fee_excess : Currency.Amount.Signed.t | |||
; supply_increase : Currency.Amount.t | |||
; supply_change : Currency.Amount.Signed.t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, why the renaming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See next answer.
src/app/cli/src/init/client.ml
Outdated
; supply_increase = w.supply_change.fee_magnitude | ||
(to_signed_fee_exn fee_excess_left.sign | ||
fee_excess_left.feeMagnitude ) | ||
; supply_change = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this renamed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In GraphQL, supplyIncrease
is deprecated in favor of supplyChange
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!ci-build-me |
Added relevant commits from #14220 to allow merge-to-develop to succeed in CI there.
Had to make some other small changes (in 8692d18) because
develop
had other changes.