Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickles ffmul plus range check support #14502

Closed
wants to merge 1 commit into from
Closed

Pickles ffmul plus range check support #14502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/lib/pickles/test/optional_custom_gates/pickles_test_optional_custom_gates.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,16 +378,28 @@ let register_feature_test (name, specific_feature_flags) =

let () =
let configurations =
[ ("xor", Plonk_types.Features.{ none_bool with xor = true })
[ ( "xor"
, Plonk_types.Features.{ none_bool with xor = true; range_check0 = true }
)
; ( "range check 0"
, Plonk_types.Features.{ none_bool with range_check0 = true } )
; ( "range check 1"
, Plonk_types.Features.{ none_bool with range_check1 = true } )
; ("rot", Plonk_types.Features.{ none_bool with rot = true })
; ( "foreign field addition"
, Plonk_types.Features.{ none_bool with foreign_field_add = true } )
; ( "foreign field multiplication"
, Plonk_types.Features.{ none_bool with foreign_field_mul = true } )
, Plonk_types.Features.
{ none_bool with
foreign_field_add = true
; range_check0 = true
; range_check1 = true
} )
; ( "foreign field multiplication" (* FIXME: this configuration fails *)
, Plonk_types.Features.
{ none_bool with
foreign_field_mul = true
; (* toggling this to `false` makes the test succeed *)
range_check0 = true
} )
; ( "Fixed lookup tables"
, Plonk_types.Features.{ none_bool with lookup = true } )
]
Expand Down
Loading