[develop] Add o1js-stub to Mina repo in place of SnarkyJS #14649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… longer needed in the project
… test-snarkyjs-bindings.sh scripts as they are no longer needed
These scripts were removed as they were no longer needed in the project. This helps to reduce clutter and confusion in the codebase.
…ts as they are no longer needed in the build process
…rs ownership to reflect recent project structure changes
MartinMinkov
requested review from
a team,
nholland94,
bkase,
aneesharaines and
mrmr1993
as code owners
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
mitschabaude
approved these changes
Dec 14, 2023
bkase
approved these changes
Dec 15, 2023
|
And same comment related to the CI and build than in #14461 |
georgeee
approved these changes
Dec 18, 2023
|
!ci-build-me |
|
!ci-build-me |
dannywillems
approved these changes
Dec 19, 2023
…of kimchi in source path to correctly locate the wasm source files
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #14466
🔗 o1js: o1-labs/o1js#1318
🔗 o1js-bindings: o1-labs/o1js-bindings#222
This PR aims to add support for building mina as a submodule of
o1js. To do so, the following was done:snarkyjssubmoduleo1js_stubmodule, that has the same dependencies as o1js. The goal with this module is to have a way for Mina CI to check that o1js can still be successfully compiled after changes are made. This gives a safety net to not totally break things if changes to the dependencies are made.kimchilibrary from o1js-bindings intosrc/lib/crypto. This is to make sure that we can compileo1js_stubsince we need the WASM dependencies generated from the library, as well as to support a longer term plan to create a o1 crypto repo that recombines the wasm bindings with o1caml-rust stubs.snarkyjs