Merged
Conversation
phertyameen
requested changes
Jan 28, 2026
Member
phertyameen
left a comment
phertyameen
left a comment
There was a problem hiding this comment.
resolve this errorr please. there are unused injections in 'src/quests/providers/complete-daily-quest.provider.ts' that will trigger cicd errors...
Mkalbani
force-pushed
the
feat/daily_quest
branch
from
62c4e6b to
b203c83
Compare
Contributor
Author
|
@phertyameen done!! |
phertyameen
approved these changes
Jan 29, 2026
Member
phertyameen
left a comment
phertyameen
left a comment
There was a problem hiding this comment.
This is Perfect!. Thank you for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #174
Implements the POST /daily-quest/complete endpoint to finalize Daily Quests.
The endpoint validates completion criteria, awards bonus XP once, and triggers streak updates, all within a transaction to ensure atomicity and safety against double submissions.
Key points
Validates today’s quest and completion status
Marks quest as completed and sets completedAt
Awards bonus XP once (idempotent behavior)
Updates user streak via the Streak provider
Transaction-safe and resistant to duplicate requests