Issue 209: Add layers accessors #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks so much nicer and cleaner than before! I have not checked every line yet. One thing I mentioned before: Why not store the thresholds in loops? (I'll add an example comment for that.) EDIT: I have looked at all of it now; looks good. But the setters should be part of this PR, I think. |
| permeability_ths_grp['low'] = world.layers['permeability'].thresholds[0][1] | ||
| permeability_ths_grp['med'] = world.layers['permeability'].thresholds[1][1] | ||
| permeability_ths_grp['low'] = world.permeability.thresholds[0][1] | ||
| permeability_ths_grp['med'] = world.permeability.thresholds[1][1] |
There was a problem hiding this comment.
I would much prefer this when it comes to storing thresholds:
for pair in world.permeability.thresholds:
permeability_ths_grp[pair[0]] = pair[1]As far as I understand the item at [x][0] is a naming string anyway. So far I haven't seen those strings used anywhere - so they could be renamed to 'low', 'med' etc., if necessary. Then the stored file would be the same as before, but the whole system could be expanded/changed more easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #209
Note that the accessors return the whole layer, then the data field has to be accessed explicitely. Also theresholds and quantiles can be accessed from the layer.