Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start refactoring to geary setter pattern #82

Merged
merged 6 commits into from
Feb 9, 2024
Merged

Conversation

0ffz
Copy link
Member

@0ffz 0ffz commented Feb 5, 2024

  • Convert different parts of furniture init process into setter actions. These are geary listeners that get called on entity spawn/reload, currently these are:
    • Setting item based on set.item, including colorable items
    • Setting MEG model
    • Setting seat height
      • Add clearFurnitureSeats method to support hotswapping, also don't persist these entities, this is a step to fully packet based seats in the future.
  • Spawn furniture via geary's AttemptSpawn system, this lets us spawn directly from prefab at a location.

@0ffz 0ffz marked this pull request as ready for review February 7, 2024 05:13
@Boy0000 Boy0000 merged commit 4f92e13 into master Feb 9, 2024
1 check passed
@Boy0000 Boy0000 deleted the geary-refactor branch February 9, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants