GitHub actions changes #21
Conversation
Remove version # defined by gradle.properties. Instead, the publish CI will now automatically generate and tag the commit based on the last version tag. The type of increment is determined by a tag on the PR, one of `major`, `minor`, or `patch`. If one of these labels is not present CI _will fail_ and no release will be generated! A few changes have been made outside of source control to this repo for these changes: 1. New labels mentioned above have been added. 2. Merges to master now requires the branch being merged into master to be completely up to date with master.
Derongan
added
type:enhancement
…tions look at the branch being merged ONTO
| - master | ||
| paths-ignore: | ||
| - .gitignore | ||
| - README.md |
There was a problem hiding this comment.
id prefer not to for now just in case. if it starts being annoying can change
| uses: actions/setup-java@v1 | ||
| with: | ||
| java-version: 1.8 | ||
| - name: Build NMS |
There was a problem hiding this comment.
No cache? :(
I'd like it if we could figure out a better way of doing it than I have with Mobzy. I wonder if it'd be possible to get that working right in the NMS action itself. The only actual problem with the way I did it is it relies on NMS version being in gradle.properties and will update cache any time properties are updated.
There was a problem hiding this comment.
seeing as this change is focused on releasing, no
There was a problem hiding this comment.
Sounds good, but I'd like to look into that later. An issue would be nice, but what repo would that belong to? I think best to put it under the nms action itself, since we should probably add some info the the README on caching anyways.
| repo_token: "${{ secrets.GITHUB_TOKEN }}" | ||
| prerelease: false | ||
| files: | | ||
| build/libs/*.jar |
There was a problem hiding this comment.
Yes. My thinking was there is no harm in releasing both. The non shaded jar may be useful for explicitly adding a dependency when developing outside of gradle.
Remove default task
Remove version # defined by gradle.properties. Instead, the publish CI will now automatically generate and tag the commit based on the last version tag. The type of increment is determined by a tag on the PR, one of
major,minor, orpatch.If one of these labels is not present CI will fail and no release will be generated!
A few changes have been made outside of source control to this repo for these changes: