Skip to content

Conversation

@Jonathing
Copy link
Member

This PR replaces the usage of JetBrains annotations with JSpecify. JSpecify is one of the newer nullable annotation standards that most people have begun to agree on, including Gradle and Mojang.

This is still a work-in-progress. Part of this PR is getting NullAway and Errorprone working for enhanced static analysis on build of ForgeGradle 7.

@Jonathing Jonathing added this to the 7.0.0 milestone Dec 8, 2025
@Jonathing Jonathing requested a review from PaintNinja December 8, 2025 03:31
@Jonathing Jonathing self-assigned this Dec 8, 2025
@Jonathing Jonathing added the enhancement Enhances an existing feature in the codebase label Dec 8, 2025
@Jonathing Jonathing marked this pull request as draft December 8, 2025 03:32
@Jonathing
Copy link
Member Author

Scrapping setting up NullAway for now, so I can get to work on more pressing matters.

@Jonathing Jonathing changed the title [7.0] Use JSpecify annotations and NullAway [7.0] Use JSpecify annotations Dec 12, 2025
@Jonathing Jonathing force-pushed the feat/jonathing/7.0/jspecify branch from 424ec56 to 6eaee56 Compare December 12, 2025 23:59
@Jonathing Jonathing marked this pull request as ready for review December 12, 2025 23:59
@Jonathing Jonathing merged commit ef7581e into MinecraftForge:FG_7.0 Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhances an existing feature in the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant