fix(*): remove update() method from newly added objs

MingboPeng · Nov 12, 2023 · 4487b7f · 4487b7f
1 parent bc90919
commit 4487b7f
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 61 deletions.
diff --git a/src/Ironbug.HVAC/AvailabilityManagers/IB_AvailabilityManagerHybridVentilation.cs b/src/Ironbug.HVAC/AvailabilityManagers/IB_AvailabilityManagerHybridVentilation.cs
@@ -22,21 +22,9 @@ public void SetControlZone(string controlZoneName)
             _controlZoneName = controlZoneName;
         }
 
-        private void UpdateFromOld()
-        {
-            var _oldZone = this.GetChild<IB_ThermalZone>();
-            if (_oldZone != null)
-            {
-                _controlZoneName = _oldZone.ZoneName;
-                this.SetChild<IB_ThermalZone>(null);
-            }
-        }
-
 
         public override OpenStudio.AvailabilityManager ToOS(Model model)
         {
-            UpdateFromOld();
-
             var obj = base.OnNewOpsObj(NewDefaultOpsObj, model);
             // this will be executed after all loops (nodes) are saved
             Func<bool> func = () =>

diff --git a/src/Ironbug.HVAC/AvailabilityManagers/IB_AvailabilityManagerNightVentilation.cs b/src/Ironbug.HVAC/AvailabilityManagers/IB_AvailabilityManagerNightVentilation.cs
@@ -22,22 +22,8 @@ public void SetControlZone(string controlZoneName)
             _controlZoneName = controlZoneName;
         }
 
-
-        private void UpdateFromOld()
-        {
-            var _oldZone = this.GetChild<IB_ThermalZone>();
-            if (_oldZone != null)
-            {
-                _controlZoneName = _oldZone.ZoneName;
-                this.SetChild<IB_ThermalZone>(null);
-            }
-        }
-
-
         public override OpenStudio.AvailabilityManager ToOS(Model model)
         {
-            UpdateFromOld();
-
             var obj = base.OnNewOpsObj(NewDefaultOpsObj, model);
             // this will be executed after all loops (nodes) are saved
             Func<bool> func = () =>

diff --git a/src/Ironbug.HVAC/AvailabilityManagers/IB_AvailabilityManagerOptimumStart.cs b/src/Ironbug.HVAC/AvailabilityManagers/IB_AvailabilityManagerOptimumStart.cs
@@ -22,20 +22,8 @@ public void SetControlZone(string controlZoneName)
             _controlZoneName = controlZoneName;
         }
 
-        private void UpdateFromOld()
-        {
-            var _oldZone = this.GetChild<IB_ThermalZone>();
-            if (_oldZone != null)
-            {
-                _controlZoneName = _oldZone.ZoneName;
-                this.SetChild<IB_ThermalZone>(null);
-            }
-        }
-
         public override OpenStudio.AvailabilityManager ToOS(Model model)
         {
-            UpdateFromOld();
-
             var obj = base.OnNewOpsObj(NewDefaultOpsObj, model);
 
             // this will be executed after all loops (nodes) are saved

diff --git a/src/Ironbug.HVAC/LoopObjs/IB_AirLoopHVACUnitaryHeatPumpAirToAir.cs b/src/Ironbug.HVAC/LoopObjs/IB_AirLoopHVACUnitaryHeatPumpAirToAir.cs
@@ -90,21 +90,9 @@ public void SetControlZone(string controlZoneName)
             _controlZoneName = controlZoneName;
         }
 
-        private void UpdateFromOld()
-        {
-            var _oldZone = this.GetChild<IB_ThermalZone>();
-            if (_oldZone != null)
-            {
-                _controlZoneName = _oldZone.ZoneName;
-                this.SetChild<IB_ThermalZone>(null);
-            }
-        }
-
         public override HVACComponent ToOS(Model model)
         {
 
-            UpdateFromOld();
-
             var obj = base.OnNewOpsObj(NewDefaultOpsObj, model);
 
             if (this._coolingCoil != null) obj.setCoolingCoil(this._coolingCoil.ToOS(model));

diff --git a/src/Ironbug.HVAC/LoopObjs/IB_AirLoopHVACUnitaryHeatPumpAirToAirMultiSpeed.cs b/src/Ironbug.HVAC/LoopObjs/IB_AirLoopHVACUnitaryHeatPumpAirToAirMultiSpeed.cs
@@ -89,19 +89,8 @@ public void SetControlZone(string controlZoneName)
             _controlZoneName = controlZoneName;
         }
 
-        private void UpdateFromOld()
-        {
-            var _oldZone = this.GetChild<IB_ThermalZone>();
-            if (_oldZone != null)
-            {
-                _controlZoneName = _oldZone.ZoneName;
-                this.SetChild<IB_ThermalZone>(null);
-            }
-        }
-
         public override HVACComponent ToOS(Model model)
         {
-            UpdateFromOld();
 
             var obj = base.OnNewOpsObj(NewDefaultOpsObj, model);