fix(Duplicate): duplicate with renewing ids

MingboPeng · Feb 7, 2024 · 66b6efa · 66b6efa
1 parent 6c21c67
commit 66b6efa
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 6 deletions.
diff --git a/src/Ironbug.Grasshopper/Component/Ironbug/BaseClasses/Ironbug_HVACComponent.cs b/src/Ironbug.Grasshopper/Component/Ironbug/BaseClasses/Ironbug_HVACComponent.cs
@@ -221,12 +221,8 @@ protected IEnumerable<IB_ModelObject> SetObjDupParamsTo(IB_ModelObject IB_obj)
                     num = Math.Max(ghInt.Value, 0);
                 }
 
-                for (int i = 0; i < num; i++)
-                {
-                    var newobj = IB_obj.Duplicate();
-                    newobj.SetTrackingID();
-                    objs.Add(newobj);
-                }
+
+                objs = IB_obj.Duplicate(num, renewIDs: true);
 
                 return objs;
 

diff --git a/src/Ironbug.HVAC/BaseClass/IB_ModelObject.cs b/src/Ironbug.HVAC/BaseClass/IB_ModelObject.cs
@@ -485,6 +485,35 @@ public virtual IB_ModelObject Duplicate()
             return this.Duplicate(IB_InitSelf);
         }
 
+        public IB_ModelObject Duplicate(bool renewId)
+        {
+            var dup = this.Duplicate();
+
+            if (renewId)
+            {
+                dup.SetTrackingID();
+                foreach (var item in dup.Children)
+                {
+                    item.SetTrackingID();
+                }
+
+            }
+
+            return dup;
+        }
+
+        public virtual List<IB_ModelObject> Duplicate(int number, bool renewIDs = true)
+        {
+            var dups = new List<IB_ModelObject>();
+            for (int i = 0; i < number; i++)
+            {
+                var newobj = this.Duplicate(renewIDs);
+                dups.Add(newobj);
+            }
+
+            return dups;
+        }
+
 
         protected T Duplicate<T>(Func<T> func) where T : IB_ModelObject
         {