Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions Comments/Comments.sln
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 16
VisualStudioVersion = 16.0.31410.357
MinimumVisualStudioVersion = 10.0.40219.1
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Comments", "Comments\Comments.vcxproj", "{74438356-D32C-4392-88FB-89F3F08A9915}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|x64 = Debug|x64
Debug|x86 = Debug|x86
Release|x64 = Release|x64
Release|x86 = Release|x86
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{74438356-D32C-4392-88FB-89F3F08A9915}.Debug|x64.ActiveCfg = Debug|x64
{74438356-D32C-4392-88FB-89F3F08A9915}.Debug|x64.Build.0 = Debug|x64
{74438356-D32C-4392-88FB-89F3F08A9915}.Debug|x86.ActiveCfg = Debug|Win32
{74438356-D32C-4392-88FB-89F3F08A9915}.Debug|x86.Build.0 = Debug|Win32
{74438356-D32C-4392-88FB-89F3F08A9915}.Release|x64.ActiveCfg = Release|x64
{74438356-D32C-4392-88FB-89F3F08A9915}.Release|x64.Build.0 = Release|x64
{74438356-D32C-4392-88FB-89F3F08A9915}.Release|x86.ActiveCfg = Release|Win32
{74438356-D32C-4392-88FB-89F3F08A9915}.Release|x86.Build.0 = Release|Win32
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {D6FB2DF2-D9A4-4AF2-84A4-E6846E85A292}
EndGlobalSection
EndGlobal
73 changes: 73 additions & 0 deletions Comments/Comments/Comments.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
#include "Comments.h"
#include <stdio.h>
#include <malloc.h>

char* readBytes(const char* filename, int* error)
{
FILE* file = fopen(filename, "r");
if (file == NULL)
{
*error = 1;
return NULL;
}
int counter = 0;
while (!feof(file))
{
char* buffer = (char*)calloc(1, sizeof(char));
{
if (buffer == NULL)
{
*error = 2;
return NULL;
}
}
const int readBytes = fscanf(file, "%c", buffer);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да ну. Аж выделение памяти на куче под один символ, только для того, чтобы его тут же удалить. Во-первых, можно было выделять место под символ на стеке (char buffer = '\0') , во-вторых, можно было не выделять место вовсе: const int readBytes = fscanf(file, "%*c");

if (readBytes < 0)
{
break;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Так буфер утечёт

}
counter++;
free(buffer);
}
fclose(file);
file = fopen(filename, "r");
Comment on lines +32 to +33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно было fseek(0);

char* data = calloc(counter, sizeof(char));
if (data == NULL)
{
*error = 2;
return NULL;
}
int linesRead = 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это уже не linesRead, а количество символов

while (!feof(file))
{
char* buffer = (char*)calloc(1, sizeof(char));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

{
if (buffer == NULL)
{
*error = 2;
return NULL;
}
}
const int readBytes = fscanf(file, "%c", buffer);
if (readBytes < 0)
{
break;
}
if (*buffer == ';')
{
while (*buffer != '\n' && *buffer != '\0' && linesRead <= counter)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно было просто сделать булевый флажок isComment, ставить его в true, если видим ";" и в false, если перевод строки. Хотя так тоже будет работать, просто сложнее.

{
data[linesRead] = *buffer;
++linesRead;
const int readBytes = fscanf(file, "%c", buffer);
if (readBytes < 0)
{
break;
}
}
}
free(buffer);
}
fclose(file);
return data;
}
4 changes: 4 additions & 0 deletions Comments/Comments/Comments.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#pragma once

// Function for reading comments from a file
char* readBytes(const char* filename, int* error);
3 changes: 3 additions & 0 deletions Comments/Comments/Comments.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
helloWorld;hello
;stackisempty
cceceececececec;list
153 changes: 153 additions & 0 deletions Comments/Comments/Comments.vcxproj
Original file line number Diff line number Diff line change
@@ -0,0 +1,153 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup Label="ProjectConfigurations">
<ProjectConfiguration Include="Debug|Win32">
<Configuration>Debug</Configuration>
<Platform>Win32</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Release|Win32">
<Configuration>Release</Configuration>
<Platform>Win32</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Debug|x64">
<Configuration>Debug</Configuration>
<Platform>x64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Release|x64">
<Configuration>Release</Configuration>
<Platform>x64</Platform>
</ProjectConfiguration>
</ItemGroup>
<PropertyGroup Label="Globals">
<VCProjectVersion>16.0</VCProjectVersion>
<Keyword>Win32Proj</Keyword>
<ProjectGuid>{74438356-d32c-4392-88fb-89f3f08a9915}</ProjectGuid>
<RootNamespace>Comments</RootNamespace>
<WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion>
</PropertyGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
<ConfigurationType>Application</ConfigurationType>
<UseDebugLibraries>true</UseDebugLibraries>
<PlatformToolset>v142</PlatformToolset>
<CharacterSet>Unicode</CharacterSet>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="Configuration">
<ConfigurationType>Application</ConfigurationType>
<UseDebugLibraries>false</UseDebugLibraries>
<PlatformToolset>v142</PlatformToolset>
<WholeProgramOptimization>true</WholeProgramOptimization>
<CharacterSet>Unicode</CharacterSet>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="Configuration">
<ConfigurationType>Application</ConfigurationType>
<UseDebugLibraries>true</UseDebugLibraries>
<PlatformToolset>v142</PlatformToolset>
<CharacterSet>Unicode</CharacterSet>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="Configuration">
<ConfigurationType>Application</ConfigurationType>
<UseDebugLibraries>false</UseDebugLibraries>
<PlatformToolset>v142</PlatformToolset>
<WholeProgramOptimization>true</WholeProgramOptimization>
<CharacterSet>Unicode</CharacterSet>
</PropertyGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
<ImportGroup Label="ExtensionSettings">
</ImportGroup>
<ImportGroup Label="Shared">
</ImportGroup>
<ImportGroup Label="PropertySheets" Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<ImportGroup Label="PropertySheets" Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<ImportGroup Label="PropertySheets" Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<ImportGroup Label="PropertySheets" Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<LinkIncremental>true</LinkIncremental>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
<LinkIncremental>false</LinkIncremental>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<LinkIncremental>true</LinkIncremental>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<LinkIncremental>false</LinkIncremental>
</PropertyGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<ClCompile>
<WarningLevel>Level3</WarningLevel>
<SDLCheck>true</SDLCheck>
<PreprocessorDefinitions>WIN32;_DEBUG;_CRT_SECURE_NO_WARNINGS;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<ConformanceMode>true</ConformanceMode>
</ClCompile>
<Link>
<SubSystem>Console</SubSystem>
<GenerateDebugInformation>true</GenerateDebugInformation>
</Link>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
<ClCompile>
<WarningLevel>Level3</WarningLevel>
<FunctionLevelLinking>true</FunctionLevelLinking>
<IntrinsicFunctions>true</IntrinsicFunctions>
<SDLCheck>true</SDLCheck>
<PreprocessorDefinitions>WIN32;NDEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<ConformanceMode>true</ConformanceMode>
</ClCompile>
<Link>
<SubSystem>Console</SubSystem>
<EnableCOMDATFolding>true</EnableCOMDATFolding>
<OptimizeReferences>true</OptimizeReferences>
<GenerateDebugInformation>true</GenerateDebugInformation>
</Link>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<ClCompile>
<WarningLevel>Level3</WarningLevel>
<SDLCheck>true</SDLCheck>
<PreprocessorDefinitions>_DEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<ConformanceMode>true</ConformanceMode>
</ClCompile>
<Link>
<SubSystem>Console</SubSystem>
<GenerateDebugInformation>true</GenerateDebugInformation>
</Link>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<ClCompile>
<WarningLevel>Level3</WarningLevel>
<FunctionLevelLinking>true</FunctionLevelLinking>
<IntrinsicFunctions>true</IntrinsicFunctions>
<SDLCheck>true</SDLCheck>
<PreprocessorDefinitions>NDEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<ConformanceMode>true</ConformanceMode>
</ClCompile>
<Link>
<SubSystem>Console</SubSystem>
<EnableCOMDATFolding>true</EnableCOMDATFolding>
<OptimizeReferences>true</OptimizeReferences>
<GenerateDebugInformation>true</GenerateDebugInformation>
</Link>
</ItemDefinitionGroup>
<ItemGroup>
<ClCompile Include="Comments.c" />
<ClCompile Include="Main.c" />
<ClCompile Include="TestComments.c" />
</ItemGroup>
<ItemGroup>
<ClInclude Include="Comments.h" />
<ClInclude Include="TestComments.h" />
</ItemGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Label="ExtensionTargets">
</ImportGroup>
</Project>
36 changes: 36 additions & 0 deletions Comments/Comments/Comments.vcxproj.filters
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup>
<Filter Include="Исходные файлы">
<UniqueIdentifier>{4FC737F1-C7A5-4376-A066-2A32D752A2FF}</UniqueIdentifier>
<Extensions>cpp;c;cc;cxx;c++;cppm;ixx;def;odl;idl;hpj;bat;asm;asmx</Extensions>
</Filter>
<Filter Include="Файлы заголовков">
<UniqueIdentifier>{93995380-89BD-4b04-88EB-625FBE52EBFB}</UniqueIdentifier>
<Extensions>h;hh;hpp;hxx;h++;hm;inl;inc;ipp;xsd</Extensions>
</Filter>
<Filter Include="Файлы ресурсов">
<UniqueIdentifier>{67DA6AB6-F800-4c08-8B7A-83BB121AAD01}</UniqueIdentifier>
<Extensions>rc;ico;cur;bmp;dlg;rc2;rct;bin;rgs;gif;jpg;jpeg;jpe;resx;tiff;tif;png;wav;mfcribbon-ms</Extensions>
</Filter>
</ItemGroup>
<ItemGroup>
<ClCompile Include="Comments.c">
<Filter>Исходные файлы</Filter>
</ClCompile>
<ClCompile Include="Main.c">
<Filter>Исходные файлы</Filter>
</ClCompile>
<ClCompile Include="TestComments.c">
<Filter>Исходные файлы</Filter>
</ClCompile>
</ItemGroup>
<ItemGroup>
<ClInclude Include="Comments.h">
<Filter>Файлы заголовков</Filter>
</ClInclude>
<ClInclude Include="TestComments.h">
<Filter>Файлы заголовков</Filter>
</ClInclude>
</ItemGroup>
</Project>
38 changes: 38 additions & 0 deletions Comments/Comments/Main.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
#include "Comments.h"
#include "testComments.h"
#include <stdio.h>

int main()
{
if (!testComments())
{
printf("Test failed");
return -1;
}
int error = 0;
const char* data = readBytes("Comments.txt", &error);
if (error == 1)
{
free(data);
printf("File not found");
return -1;
}
if (error == 2)
{
free(data);
printf("Memory not allocated");
return -1;
}
printf("all comments :");
int i = 0;
while (data[i] != '\0')
{
if (data[i] == ';')
{
printf("\n");
}
printf("%c", data[i]);
i++;
}
free(data);
}
3 changes: 3 additions & 0 deletions Comments/Comments/Test.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
asdsadasd;helloworld
;helloworld))
wefewfewfe;kek
19 changes: 19 additions & 0 deletions Comments/Comments/TestComments.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#include "testComments.h"
#include "Comments.h"

bool testComments()
{
int error = 0;
char* data = readBytes("Test.txt", &error);
int i = 0;
const char arrayOfSymbol[29] = ";helloworld;helloworld));kek";
while (data[i] != '\0' && arrayOfSymbol[i] != '\0')
{
if (data[i] != arrayOfSymbol[i])
{
return false;
}
i++;
}
return true;
}
5 changes: 5 additions & 0 deletions Comments/Comments/TestComments.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
#pragma once
#include <stdbool.h>

//A function for testing a function that reads comments from a file
bool testComments();