Skip to content

Test #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MinyazevR wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Test #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e3e907
...
MinyazevR Oct 5, 2021
5dfa659
...
MinyazevR Oct 5, 2021
c7bb922
...
MinyazevR Oct 5, 2021
4bac746
...
MinyazevR Oct 5, 2021
c46ec8b
...
MinyazevR Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions arrayOFNumbers/arrayOFNumbers.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 16
VisualStudioVersion = 16.0.31410.357
MinimumVisualStudioVersion = 10.0.40219.1
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "arrayOFNumbers", "arrayOFNumbers\arrayOFNumbers.vcxproj", "{82B95909-9910-4ED3-8EB1-1735D9D0D34B}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|x64 = Debug|x64
Debug|x86 = Debug|x86
Release|x64 = Release|x64
Release|x86 = Release|x86
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{82B95909-9910-4ED3-8EB1-1735D9D0D34B}.Debug|x64.ActiveCfg = Debug|x64
{82B95909-9910-4ED3-8EB1-1735D9D0D34B}.Debug|x64.Build.0 = Debug|x64
{82B95909-9910-4ED3-8EB1-1735D9D0D34B}.Debug|x86.ActiveCfg = Debug|Win32
{82B95909-9910-4ED3-8EB1-1735D9D0D34B}.Debug|x86.Build.0 = Debug|Win32
{82B95909-9910-4ED3-8EB1-1735D9D0D34B}.Release|x64.ActiveCfg = Release|x64
{82B95909-9910-4ED3-8EB1-1735D9D0D34B}.Release|x64.Build.0 = Release|x64
{82B95909-9910-4ED3-8EB1-1735D9D0D34B}.Release|x86.ActiveCfg = Release|Win32
{82B95909-9910-4ED3-8EB1-1735D9D0D34B}.Release|x86.Build.0 = Release|Win32
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {DCB43279-7E4D-409C-AF4E-9A003FFFC193}
EndGlobalSection
EndGlobal
147 changes: 147 additions & 0 deletions arrayOFNumbers/arrayOFNumbers/arrayOFNumbers.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,147 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup Label="ProjectConfigurations">
<ProjectConfiguration Include="Debug|Win32">
<Configuration>Debug</Configuration>
<Platform>Win32</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Release|Win32">
<Configuration>Release</Configuration>
<Platform>Win32</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Debug|x64">
<Configuration>Debug</Configuration>
<Platform>x64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Release|x64">
<Configuration>Release</Configuration>
<Platform>x64</Platform>
</ProjectConfiguration>
</ItemGroup>
<PropertyGroup Label="Globals">
<VCProjectVersion>16.0</VCProjectVersion>
<Keyword>Win32Proj</Keyword>
<ProjectGuid>{82b95909-9910-4ed3-8eb1-1735d9d0d34b}</ProjectGuid>
<RootNamespace>arrayOFNumbers</RootNamespace>
<WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion>
</PropertyGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
<ConfigurationType>Application</ConfigurationType>
<UseDebugLibraries>true</UseDebugLibraries>
<PlatformToolset>v142</PlatformToolset>
<CharacterSet>Unicode</CharacterSet>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="Configuration">
<ConfigurationType>Application</ConfigurationType>
<UseDebugLibraries>false</UseDebugLibraries>
<PlatformToolset>v142</PlatformToolset>
<WholeProgramOptimization>true</WholeProgramOptimization>
<CharacterSet>Unicode</CharacterSet>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="Configuration">
<ConfigurationType>Application</ConfigurationType>
<UseDebugLibraries>true</UseDebugLibraries>
<PlatformToolset>v142</PlatformToolset>
<CharacterSet>Unicode</CharacterSet>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="Configuration">
<ConfigurationType>Application</ConfigurationType>
<UseDebugLibraries>false</UseDebugLibraries>
<PlatformToolset>v142</PlatformToolset>
<WholeProgramOptimization>true</WholeProgramOptimization>
<CharacterSet>Unicode</CharacterSet>
</PropertyGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
<ImportGroup Label="ExtensionSettings">
</ImportGroup>
<ImportGroup Label="Shared">
</ImportGroup>
<ImportGroup Label="PropertySheets" Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<ImportGroup Label="PropertySheets" Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<ImportGroup Label="PropertySheets" Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<ImportGroup Label="PropertySheets" Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<LinkIncremental>true</LinkIncremental>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
<LinkIncremental>false</LinkIncremental>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<LinkIncremental>true</LinkIncremental>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<LinkIncremental>false</LinkIncremental>
</PropertyGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<ClCompile>
<WarningLevel>Level3</WarningLevel>
<SDLCheck>true</SDLCheck>
<PreprocessorDefinitions>WIN32;_DEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<ConformanceMode>true</ConformanceMode>
</ClCompile>
<Link>
<SubSystem>Console</SubSystem>
<GenerateDebugInformation>true</GenerateDebugInformation>
</Link>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
<ClCompile>
<WarningLevel>Level3</WarningLevel>
<FunctionLevelLinking>true</FunctionLevelLinking>
<IntrinsicFunctions>true</IntrinsicFunctions>
<SDLCheck>true</SDLCheck>
<PreprocessorDefinitions>WIN32;NDEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<ConformanceMode>true</ConformanceMode>
</ClCompile>
<Link>
<SubSystem>Console</SubSystem>
<EnableCOMDATFolding>true</EnableCOMDATFolding>
<OptimizeReferences>true</OptimizeReferences>
<GenerateDebugInformation>true</GenerateDebugInformation>
</Link>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<ClCompile>
<WarningLevel>Level3</WarningLevel>
<SDLCheck>true</SDLCheck>
<PreprocessorDefinitions>_DEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<ConformanceMode>true</ConformanceMode>
</ClCompile>
<Link>
<SubSystem>Console</SubSystem>
<GenerateDebugInformation>true</GenerateDebugInformation>
</Link>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<ClCompile>
<WarningLevel>Level3</WarningLevel>
<FunctionLevelLinking>true</FunctionLevelLinking>
<IntrinsicFunctions>true</IntrinsicFunctions>
<SDLCheck>true</SDLCheck>
<PreprocessorDefinitions>NDEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<ConformanceMode>true</ConformanceMode>
</ClCompile>
<Link>
<SubSystem>Console</SubSystem>
<EnableCOMDATFolding>true</EnableCOMDATFolding>
<OptimizeReferences>true</OptimizeReferences>
<GenerateDebugInformation>true</GenerateDebugInformation>
</Link>
</ItemDefinitionGroup>
<ItemGroup>
<ClCompile Include="arrayOfNumbers.c" />
</ItemGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Label="ExtensionTargets">
</ImportGroup>
</Project>
22 changes: 22 additions & 0 deletions arrayOFNumbers/arrayOFNumbers/arrayOFNumbers.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup>
<Filter Include="Исходные файлы">
<UniqueIdentifier>{4FC737F1-C7A5-4376-A066-2A32D752A2FF}</UniqueIdentifier>
<Extensions>cpp;c;cc;cxx;c++;cppm;ixx;def;odl;idl;hpj;bat;asm;asmx</Extensions>
</Filter>
<Filter Include="Файлы заголовков">
<UniqueIdentifier>{93995380-89BD-4b04-88EB-625FBE52EBFB}</UniqueIdentifier>
<Extensions>h;hh;hpp;hxx;h++;hm;inl;inc;ipp;xsd</Extensions>
</Filter>
<Filter Include="Файлы ресурсов">
<UniqueIdentifier>{67DA6AB6-F800-4c08-8B7A-83BB121AAD01}</UniqueIdentifier>
<Extensions>rc;ico;cur;bmp;dlg;rc2;rct;bin;rgs;gif;jpg;jpeg;jpe;resx;tiff;tif;png;wav;mfcribbon-ms</Extensions>
</Filter>
</ItemGroup>
<ItemGroup>
<ClCompile Include="arrayOfNumbers.c">
<Filter>Исходные файлы</Filter>
</ClCompile>
</ItemGroup>
</Project>
65 changes: 65 additions & 0 deletions arrayOFNumbers/arrayOFNumbers/arrayOfNumbers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
#include <stdio.h>
#include <stdlib.h>
#include <locale.h>
#include <stdbool.h>

bool test()
{
int arrayOFNumber[10] = {199, 36, 123, 1, 2, 6, 8, 9, 7, 10};
int sum[10] = {0};
return largestSun(arrayOFNumber, sum, 10) == 0;
Copy link

@yurii-litvinov yurii-litvinov Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

largestSun пока ещё не объявлен, должно быть предупреждение компилятора


Copy link

@yurii-litvinov yurii-litvinov Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

}
Copy link

@yurii-litvinov yurii-litvinov Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я бы не сказал, что этот тест уж совсем ничего не тестирует, но он не тестирует выполнение условия задачи, а именно "Если таких чисел несколько, вывести на экран все эти числа".


int largestSun(int *array,int* sum,int numberOfElements)
Copy link

@yurii-litvinov yurii-litvinov Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Самое большое Солнце"? :) Должно быть largestSum, наверное

Copy link

@yurii-litvinov yurii-litvinov Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int largestSun(int *array,int* sum,int numberOfElements)
int largestSun(int *array, int* sum, int numberOfElements)

{
for (int i = 0; i < numberOfElements; i++)
{
while (array[i] > 0)
{
sum[i] += array[i] % 10;
array[i] /= 10;
Copy link

@yurii-litvinov yurii-litvinov Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Обнуление переданного массива может быть неожиданно для вызывающего

}
}
int temporary = sum[0];
int j = 0;
Copy link

@yurii-litvinov yurii-litvinov Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j я бы тоже назвал как-то более по-человечески, например, largestSumIndex

for (int i = 1; i < numberOfElements; i++)
{
if (sum[i] > temporary)
{
temporary = sum[i];
j = i;
}
}
return j;
}
Copy link

@yurii-litvinov yurii-litvinov Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

int main()
{
setlocale(LC_ALL, "rus");
if (!test())
{
return -1;
}
setlocale(LC_ALL, "rus");
int numberOfElements = 0;
printf("������� ���������� ���������");
scanf_s("%d", &numberOfElements);
int* array = calloc(numberOfElements, sizeof(int));
if (array == 0)
Copy link

@yurii-litvinov yurii-litvinov Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (array == 0)
if (array == NULL)

Это то же самое, но поскольку array --- это указатель, константа NULL больше подходит по смыслу

{
return -1;
}
int* sum = calloc(numberOfElements, sizeof(int));
Copy link

@yurii-litvinov yurii-litvinov Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если уж largestSun заполняет массив, она же могла бы его и создавать

if (sum == 0)
{
return -1;
Copy link

@yurii-litvinov yurii-litvinov Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не-а, так array не будет освобождён никогда (ну то есть на самом деле при завершении работы программы ОС освобождает всю занятую ей память, но если мы захотим скопипастить такой код в какую-то свою функцию, чтобы return просто возвращал управление, а не выходил из программы, будет самая настоящая утечка памяти, которую будет трудно отладить).

}
for (int i = 0; i < numberOfElements; i++)
{
array[i] = rand();
}
int k = largestSun(array,sum, numberOfElements);
Copy link

@yurii-litvinov yurii-litvinov Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int k = largestSun(array,sum, numberOfElements);
int k = largestSun(array, sum, numberOfElements);

printf("����� %d ����� ����%d", k, array[k]);
Copy link

@yurii-litvinov yurii-litvinov Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это не то, что хотелось. "Если таких чисел несколько, вывести на экран все эти числа" не делается.

free(array);
free(sum);
}
31 changes: 31 additions & 0 deletions epeatingElements/epeatingElements.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 16
VisualStudioVersion = 16.0.31410.357
MinimumVisualStudioVersion = 10.0.40219.1
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "epeatingElements", "epeatingElements\epeatingElements.vcxproj", "{9CAAE94E-3BD7-405C-9490-4567B6DC22CF}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|x64 = Debug|x64
Debug|x86 = Debug|x86
Release|x64 = Release|x64
Release|x86 = Release|x86
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{9CAAE94E-3BD7-405C-9490-4567B6DC22CF}.Debug|x64.ActiveCfg = Debug|x64
{9CAAE94E-3BD7-405C-9490-4567B6DC22CF}.Debug|x64.Build.0 = Debug|x64
{9CAAE94E-3BD7-405C-9490-4567B6DC22CF}.Debug|x86.ActiveCfg = Debug|Win32
{9CAAE94E-3BD7-405C-9490-4567B6DC22CF}.Debug|x86.Build.0 = Debug|Win32
{9CAAE94E-3BD7-405C-9490-4567B6DC22CF}.Release|x64.ActiveCfg = Release|x64
{9CAAE94E-3BD7-405C-9490-4567B6DC22CF}.Release|x64.Build.0 = Release|x64
{9CAAE94E-3BD7-405C-9490-4567B6DC22CF}.Release|x86.ActiveCfg = Release|Win32
{9CAAE94E-3BD7-405C-9490-4567B6DC22CF}.Release|x86.Build.0 = Release|Win32
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {F5178FEF-DC23-41A3-9F99-E0104B4F0378}
EndGlobalSection
EndGlobal
Loading