Merge branch 'feat/scroll-on-touch' #1
Annotations
21 errors and 14 warnings
Build, lint, and test on Node 12.x and ubuntu-latest:
src/Canvas/index.tsx#L1
Replace `"react"` with `'react'`
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/Canvas/index.tsx#L83
Replace `"pen"·|·"mouse"·|·"touch"·|·null>(null` with `'pen'·|·'mouse'·|·'touch'·|·null>(⏎····null⏎··`
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/Canvas/index.tsx#L113
Replace `"touch"` with `'touch'`
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/Canvas/index.tsx#L132
Replace `(event.buttons·&·32)·===·32)` with `event.buttons·&·32)·===·32`
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/Canvas/index.tsx#L143
Replace `"touch"` with `'touch'`
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/Canvas/index.tsx#L164
Replace `"touch"` with `'touch'`
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/Canvas/index.tsx#L294
Replace `(⏎······this:·HTMLDivElement,⏎······event:·TouchEvent⏎····` with `·(this:·HTMLDivElement,·event:·TouchEvent`
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/Canvas/index.tsx#L298
Replace `"pen"` with `'pen'`
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/Canvas/index.tsx#L305
Replace `"touchstart",·listener,·{·passive:·false` with `'touchstart',·listener,·{⏎········passive:·false,⏎·····`
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/Canvas/index.tsx#L307
Replace `"touchstart"` with `'touchstart'`
|
Build, lint, and test on Node 14.x and ubuntu-latest
The job was canceled because "_12_x_ubuntu-latest" failed.
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/Canvas/index.tsx#L1
Replace `"react"` with `'react'`
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/Canvas/index.tsx#L83
Replace `"pen"·|·"mouse"·|·"touch"·|·null>(null` with `'pen'·|·'mouse'·|·'touch'·|·null>(⏎····null⏎··`
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/Canvas/index.tsx#L113
Replace `"touch"` with `'touch'`
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/Canvas/index.tsx#L132
Replace `(event.buttons·&·32)·===·32)` with `event.buttons·&·32)·===·32`
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/Canvas/index.tsx#L143
Replace `"touch"` with `'touch'`
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/Canvas/index.tsx#L164
Replace `"touch"` with `'touch'`
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/Canvas/index.tsx#L294
Replace `(⏎······this:·HTMLDivElement,⏎······event:·TouchEvent⏎····` with `·(this:·HTMLDivElement,·event:·TouchEvent`
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/Canvas/index.tsx#L298
Replace `"pen"` with `'pen'`
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/Canvas/index.tsx#L305
Replace `"touchstart",·listener,·{·passive:·false` with `'touchstart',·listener,·{⏎········passive:·false,⏎·····`
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/Canvas/index.tsx#L307
Replace `"touchstart"` with `'touchstart'`
|
Build, lint, and test on Node 12.x and ubuntu-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-node@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Build, lint, and test on Node 12.x and ubuntu-latest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/Canvas/index.tsx#L160
The 'handlePointerUp' function makes the dependencies of useEffect Hook (at line 270) change on every render. To fix this, wrap the definition of 'handlePointerUp' in its own useCallback() Hook
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/Canvas/index.tsx#L307
The ref value 'canvasRef.current' will likely have changed by the time this effect cleanup function runs. If this ref points to a node rendered by React, copy 'canvasRef.current' to a variable inside the effect, and use that variable in the cleanup function
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/Canvas/index.tsx#L308
React Hook useEffect has a missing dependency: 'scrollOnTouch'. Either include it or remove the dependency array
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/ReactSketchCanvas/index.tsx#L86
React Hook React.useCallback has missing dependencies: 'currentPaths' and 'onStroke'. Either include them or remove the dependency array
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/ReactSketchCanvas/index.tsx#L90
React Hook React.useEffect has a missing dependency: 'liftStrokeUp'. Either include it or remove the dependency array
|
Build, lint, and test on Node 12.x and ubuntu-latest:
src/ReactSketchCanvas/index.tsx#L94
React Hook React.useEffect has a missing dependency: 'onChange'. Either include it or remove the dependency array
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/Canvas/index.tsx#L160
The 'handlePointerUp' function makes the dependencies of useEffect Hook (at line 270) change on every render. To fix this, wrap the definition of 'handlePointerUp' in its own useCallback() Hook
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/Canvas/index.tsx#L307
The ref value 'canvasRef.current' will likely have changed by the time this effect cleanup function runs. If this ref points to a node rendered by React, copy 'canvasRef.current' to a variable inside the effect, and use that variable in the cleanup function
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/Canvas/index.tsx#L308
React Hook useEffect has a missing dependency: 'scrollOnTouch'. Either include it or remove the dependency array
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/ReactSketchCanvas/index.tsx#L86
React Hook React.useCallback has missing dependencies: 'currentPaths' and 'onStroke'. Either include them or remove the dependency array
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/ReactSketchCanvas/index.tsx#L90
React Hook React.useEffect has a missing dependency: 'liftStrokeUp'. Either include it or remove the dependency array
|
Build, lint, and test on Node 14.x and ubuntu-latest:
src/ReactSketchCanvas/index.tsx#L94
React Hook React.useEffect has a missing dependency: 'onChange'. Either include it or remove the dependency array
|