Skip to content

feat. Elevator Displays#166

Open
LimeShep wants to merge 3 commits intoMisterJulsen:mc/1.20.1-C6-DL3from
LimeShep:1.18.2
Open

feat. Elevator Displays#166
LimeShep wants to merge 3 commits intoMisterJulsen:mc/1.20.1-C6-DL3from
LimeShep:1.18.2

Conversation

@LimeShep
Copy link
Copy Markdown

Adds the ability to use displays in elevators.
Available placeholders:
%elevator.current.short% // Short name of the current floor eg. 0
%elevator.current.long% // Long name of the current floor eg. Main Lobby
%elevator.destination.short% // Short name of the floor the elevator is heading to, eg. 21
%elevator.destination.long% // Long name of the floor the elevator is heading, eg. Gym
%elevator.sign% // Arrows indicating if the elevator is moving up or down
%elevator.sign.triangle% // The same thing as above but using a different pair of characters.

@LimeShep
Copy link
Copy Markdown
Author

don't worry about the name of the branch, it's the same branch as you have right now.

@C1200
Copy link
Copy Markdown
Contributor

C1200 commented Mar 31, 2026

in my opinion, ElevatorData.sign should be an enum since it should only ever be up or down. also im curious as to why you used zero width non joiners at the end of each returned replacement. other than that, it looks alright from my quick skim through.

@LimeShep
Copy link
Copy Markdown
Author

LimeShep commented Apr 1, 2026

zero width non joiners were used because the display treated "1" as an integer instead of a string (or idk really) and that made every text placed after the integer to be wiped. An example of that is listed in my comment

  • %elevator.current.short% %elevator.current.sign% | renders as 1 even if the elevator is moving (this happened with any text placed after elevator.current.short, even things as simple as the letter "A").

The use of ZWNJ's solves that issue especially because they are not visible in contrast to Zero Width Space which shows a box, but it should be investigated on why that happens.

Also I have changed the code so ElevatorData.sign is now of enum ElevatorMovementType.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants