feat. Elevator Displays#166
Conversation
|
don't worry about the name of the branch, it's the same branch as you have right now. |
|
in my opinion, ElevatorData.sign should be an enum since it should only ever be up or down. also im curious as to why you used zero width non joiners at the end of each returned replacement. other than that, it looks alright from my quick skim through. |
|
zero width non joiners were used because the display treated "1" as an integer instead of a string (or idk really) and that made every text placed after the integer to be wiped. An example of that is listed in my comment
The use of ZWNJ's solves that issue especially because they are not visible in contrast to Zero Width Space which shows a box, but it should be investigated on why that happens. Also I have changed the code so ElevatorData.sign is now of enum ElevatorMovementType. |
Adds the ability to use displays in elevators.
Available placeholders:
%elevator.current.short% // Short name of the current floor eg. 0
%elevator.current.long% // Long name of the current floor eg. Main Lobby
%elevator.destination.short% // Short name of the floor the elevator is heading to, eg. 21
%elevator.destination.long% // Long name of the floor the elevator is heading, eg. Gym
%elevator.sign% // Arrows indicating if the elevator is moving up or down
%elevator.sign.triangle% // The same thing as above but using a different pair of characters.