Skip to content

Allow running tests on unpacked crate #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

bgilbert
Copy link
Contributor

Downstream Linux distros may want to run the tests as part of their package build process, but will only have our packaged crate, not a Git checkout. Include test fixtures in the crate, and fix a test that assumes the availability of a commit hash.

@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9735894504

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 97.32%

Files with Coverage Reduction New Missed Lines %
src/view.rs 1 95.96%
Totals Coverage Status
Change from base Build 9689115722: -0.02%
Covered Lines: 4575
Relevant Lines: 4701

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9793705786

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 97.32%

Files with Coverage Reduction New Missed Lines %
src/view.rs 1 95.96%
Totals Coverage Status
Change from base Build 9689115722: -0.02%
Covered Lines: 4575
Relevant Lines: 4701

💛 - Coveralls

bgilbert added 2 commits July 4, 2024 16:40
If we're building tests from an unpacked crate instead of a Git repo, we
won't have a commit hash.
Allow downstream distros to run tests when building a binary package.
@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9800148094

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.341%

Totals Coverage Status
Change from base Build 9794837187: 0.02%
Covered Lines: 4576
Relevant Lines: 4701

💛 - Coveralls

@MitMaro MitMaro enabled auto-merge (rebase) July 4, 2024 22:35
@MitMaro MitMaro disabled auto-merge July 4, 2024 22:35
@MitMaro MitMaro merged commit b5b7dc6 into MitMaro:master Jul 4, 2024
7 checks passed
@bgilbert bgilbert deleted the tests branch July 4, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants