Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libretro-snes9x2002: Add loading hacks from snesadvance.dat file #126

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

tiopex
Copy link
Contributor

@tiopex tiopex commented Sep 15, 2024

Add loading hacks from snesadvance.dat file function from drPocketSnes emu

@tiopex tiopex force-pushed the master branch 2 times, most recently from 7487c15 to e6ce827 Compare September 15, 2024 21:44
@tiopex tiopex changed the title Add loading hacks from snesadvance.dat file libretro-snes9x2002: Add loading hacks from snesadvance.dat file Sep 15, 2024
@tiopex tiopex marked this pull request as ready for review September 16, 2024 12:27
@Apaczer
Copy link
Member

Apaczer commented Sep 16, 2024

AFAIR the speedhacks may brake/reduce accuracy on some parts (by skipping some CPU cycles), so you would likely want to make it optional.
BTW there is dynarec code in snes9x2002 which may help with snes9x2005 (see https://git.crowdedwood.com/snes9x2005/log/?h=performance)

@tiopex
Copy link
Contributor Author

tiopex commented Sep 16, 2024

That's the plan to add an option to the ra settings

@Apaczer
Copy link
Member

Apaczer commented Sep 16, 2024

You should merge here only then and if succed try to push it upstream, some ppl may like it. Considering it hasn't got any signiffact updates in years (last from @jSTE0, cheers!).

@jSTE0
Copy link

jSTE0 commented Sep 16, 2024

Previously discussed in TriForceX/MiyooCFW#479 in the context of snes9x4d and was known to break some games as noted in TriForceX/MiyooCFW#380.

Copy link
Member

@Apaczer Apaczer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work 👍 ("Batman Returs" brakes at startup), but you need full core restart (close and launch again).
Anyway I'm going offline for a month (✈️ ), so this will be my last request.

package/libretro-snes9x2002/0002-Add-snesadvance.patch Outdated Show resolved Hide resolved
Copy link
Member

@Apaczer Apaczer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally this shouldn't be enabled by default, so I will leave merging to you 😏

@tiopex
Copy link
Contributor Author

tiopex commented Oct 14, 2024

Done

@Apaczer Apaczer merged commit 81270d9 into MiyooCFW:master Oct 14, 2024
4 checks passed
@Apaczer
Copy link
Member

Apaczer commented Oct 14, 2024

GJ on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants