Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIYOO_KBD] Fix keyboard for RS-77 #74

Closed
wants to merge 1 commit into from
Closed

Conversation

tiopex
Copy link
Contributor

@tiopex tiopex commented Oct 9, 2023

On RS-77 (yet another SUP M3 clone) when IN_PA1 == 1 then IN_2 cannot go to 1. So it needs to add the condition that IN_PA1 must always be 0 when checking IN_2.

@tiopex tiopex changed the title Fix keyboard for RS-77 [MIYOO_KBD] Fix keyboard for RS-77 Oct 9, 2023
@Apaczer
Copy link
Member

Apaczer commented Oct 9, 2023

If you're refering TriForceX/MiyooCFW#518 then it should be MY_L1 (from the face buttons layout) which can't be registered with LEFT/RIGHT pressed from what he says (or is it opposite?). Does that button combo works on your device?

Well I can not test it on real HW, but while we are at it then we might as well do another kbd.variant for RS-77 and one more for M3S while commenting out below code:

if(gpio_get_value(IN_1) == 1 && gpio_get_value(IN_2) == 0){
val|= MY_START;
}

From what I heard they don't explicit this issue as SUP M3 do.

@tiopex
Copy link
Contributor Author

tiopex commented Oct 9, 2023

Screenshot_20231009-221313~2
According iotester it is IN_PA1

@Apaczer
Copy link
Member

Apaczer commented Oct 9, 2023

Well is he using official build from our actions runner?

@tiopex
Copy link
Contributor Author

tiopex commented Oct 9, 2023

I think so, on other screen I see boot logo with miyoocfw

@geek-sc
Copy link

geek-sc commented Oct 10, 2023

Well is he using official build from our actions runner?

Hello, thank you very much for your reply. I am using this RS77. Although it looks similar to M3, its buttons may be different from M3. The system firmware I am currently using may have been modified by someone else, or it may have been an error during the modification, causing me to be unable to press the left and right buttons simultaneously with the B key.

@geek-sc
Copy link

geek-sc commented Oct 10, 2023

Well is he using official build from our actions runner?

And the screen driver of RS77 also needs to be adapted. The color and direction of the power on are opposite, and it was not normal after entering the system. After I modified the options.cfg in MIAN, it became normal

image

@geek-sc
Copy link

geek-sc commented Oct 10, 2023

If you're refering TriForceX/MiyooCFW#518 then it should be MY_L1 (from the face buttons layout) which can't be registered with LEFT/RIGHT pressed from what he says (or is it opposite?). Does that button combo works on your device?

Well I can not test it on real HW, but while we are at it then we might as well do another kbd.variant for RS-77 and one more for M3S while commenting out below code:

if(gpio_get_value(IN_1) == 1 && gpio_get_value(IN_2) == 0){
val|= MY_START;
}

From what I heard they don't explicit this issue as SUP M3 do.

M3 should not have this issue because RS77 is a different model and it has an additional cross direction key compared to M3, and the buttons may also be different. Because I am using a kernel that has been modified by someone else to adapt to RS77, it is not an official kernel, so even if I modify the M3 kernel, I cannot use it normally.

@geek-sc
Copy link

geek-sc commented Oct 10, 2023

Thank you very much, but currently, it seems inappropriate to directly modify the M3 buttons. It is indeed necessary to re adapt to the RS77 model, as I have tested using the M3 button kernel directly. RS77 cannot use the buttons properly and is not compatible.

@tiopex
Copy link
Contributor Author

tiopex commented Oct 10, 2023

Ok, this require to add support for RS-77 into official miyoo kernel first, so I'm closing this PR

@tiopex tiopex closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants