Sourcery refactored master branch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| res = [mat.upper() for mat in m] | ||
| return res | ||
| return [mat.upper() for mat in m] |
There was a problem hiding this comment.
Function get_matieres refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-16
to
+18
| nomEmplacementSauvegarde = ou + "/" + doss | ||
| nomEmplacementSauvegarde = f"{ou}/{doss}" | ||
| if not os.path.exists(nomEmplacementSauvegarde): | ||
| os.mkdir(nomEmplacementSauvegarde) | ||
| return nomEmplacementSauvegarde | ||
| else: | ||
| return nomEmplacementSauvegarde | ||
| return nomEmplacementSauvegarde |
There was a problem hiding this comment.
Function CreerDossierSauvegarde refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation) - Hoist repeated code outside conditional statement (
hoist-statement-from-if)
Comment on lines
-29
to
+26
| if diff < 1000: | ||
| return True, diff | ||
| else: | ||
| return False, diff | ||
| return (True, diff) if diff < 1000 else (False, diff) |
There was a problem hiding this comment.
Function SemblableFichier refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-40
to
+34
| print("Impossible de supprimer le fichier " + path + " car il n'existe pas") | ||
| print(f"Impossible de supprimer le fichier {path} car il n'existe pas") |
There was a problem hiding this comment.
Function SupprimerFichier refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Comment on lines
-62
to
+66
| if not nomMatiere == listeMatieres[-1]: | ||
| nomEmplacementSauvegarde = CreerDossierSauvegarde(CreerDossierSauvegarde("H:/Desktop", "SCREENEY"), "- " + nomMatiere) | ||
| if nomMatiere != listeMatieres[-1]: | ||
| nomEmplacementSauvegarde = CreerDossierSauvegarde( | ||
| CreerDossierSauvegarde("H:/Desktop", "SCREENEY"), f"- {nomMatiere}" | ||
| ) | ||
|
|
||
| path = nomEmplacementSauvegarde | ||
| path = path.replace('/','\\') | ||
|
|
||
| print("open", path) | ||
| if os.path.exists(path): | ||
| command = 'explorer.exe ' + path | ||
| command = f'explorer.exe {path}' |
There was a problem hiding this comment.
Function open_folder refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan) - Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Comment on lines
-91
to
+124
| if not nomMatiere == listeMatieres[-1]: | ||
| if nomMatiere != listeMatieres[-1]: | ||
| nomEmplacementSauvegarde = CreerDossierSauvegarde( | ||
| CreerDossierSauvegarde(CreerDossierSauvegarde("h:/Desktop", "SCREENEY"), "- " + nomMatiere.lower()), | ||
| datetime.datetime.now().strftime('%Y-%m-%d (%a)')) | ||
| CreerDossierSauvegarde( | ||
| CreerDossierSauvegarde("h:/Desktop", "SCREENEY"), | ||
| f"- {nomMatiere.lower()}", | ||
| ), | ||
| datetime.datetime.now().strftime('%Y-%m-%d (%a)'), | ||
| ) | ||
|
|
||
| comm = Comment.get() | ||
| comm = comm.strip() | ||
| if len(comm) > 0: | ||
| comm = ' ' + comm | ||
| comm = f' {comm}' | ||
|
|
||
| myDatetime = datetime.datetime.now() | ||
| nomFichier = myDatetime.strftime('%Y-%m-%d-%H%M%S' + comm) | ||
| photo = nomEmplacementSauvegarde + "/" + nomFichier + ".png" | ||
| nomFichier = myDatetime.strftime(f'%Y-%m-%d-%H%M%S{comm}') | ||
| photo = f"{nomEmplacementSauvegarde}/{nomFichier}.png" | ||
|
|
||
| # prendre photo | ||
| pyautogui.screenshot(photo) | ||
| print("#" + str(c) + "# " + photo) | ||
| print(f"#{str(c)}# {photo}") | ||
|
|
||
| # pour les photo sauf la premiere | ||
| if (c > 0): | ||
| # si photo semblable a lancienne photo alors suprr photo | ||
| semblable = SemblableFichier(photo, ancienphoto) | ||
| if semblable[0]: | ||
| print(">>> PAREIL! " + str(semblable[1]) + " # " + photo + " VS " + ancienphoto) | ||
| print(f">>> PAREIL! {str(semblable[1])} # {photo} VS {ancienphoto}") | ||
| label.config(text="Image similaire ! Je cala pas", fg='red') | ||
| SupprimerFichier(photo) | ||
| # sinon, si nouvelle photo | ||
| else: | ||
| c += 1 | ||
| label.config(text="#" + str(c) + " ▪ " + photo.split('/')[-1], fg='green') | ||
| label.config(text=f"#{c} ▪ " + photo.split('/')[-1], fg='green') | ||
| ancienphoto = photo | ||
|
|
||
| else: | ||
| c += 1 | ||
| label.config(text="#" + str(c) + " ▪ " + photo.split('/')[-1], fg='green') | ||
| label.config(text=f"#{c} ▪ " + photo.split('/')[-1], fg='green') |
There was a problem hiding this comment.
Function capturer refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan) - Use f-string instead of string concatenation [×18] (
use-fstring-for-concatenation) - Remove unnecessary calls to
str()from formatted values in f-strings [×2] (remove-str-from-fstring)
This removes the following comments ( why? ):
# sinon, si nouvelle photo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!