Fix CORS headers missing on error responses in desktop app#272
Merged
Mng-dev-ai merged 2 commits intomainfrom Feb 22, 2026
Merged
Fix CORS headers missing on error responses in desktop app#272Mng-dev-ai merged 2 commits intomainfrom
Mng-dev-ai merged 2 commits intomainfrom
Conversation
Move CORSMiddleware to be the outermost middleware so CORS headers are always present — even on 500s from inner middleware. Previously, error responses bypassed CORS, causing WebKit to block them entirely and preventing the frontend from reading the status code to invalidate stale sessions. Also simplify shouldInvalidateSession to a single expression.
Only invalidate the session when the refresh endpoint returns 401 (token is genuinely invalid). Other 4xx like 429 (rate limited) or 422 (validation error) are transient and shouldn't log the user out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CORSMiddlewareis the outermost (last added), ensuring CORS headers are present on all responses including 500s from inner middlewareRequestIdMiddlewareorSecurityHeadersMiddlewarebypassedCORSMiddleware, causing WebKit in Tauri to block the response entirely — the frontend couldn't read the status code to handle auth failuresshouldInvalidateSessionfrom multiple early returns to a single expressionTest plan