Skip to content

Commit

Permalink
v0.5.9: bug fixes affecting human and pass1c
Browse files Browse the repository at this point in the history
  • Loading branch information
biodavidjm committed Aug 11, 2021
1 parent c70e58e commit 11df94d
Show file tree
Hide file tree
Showing 65 changed files with 90 additions and 76 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Package: MotrpacBicQC
Type: Package
Title: QC/QA functions for the MoTrPAC community
Version: 0.5.8
Date: 2021-08-06
Version: 0.5.9
Date: 2021-08-10
Author: MoTrPAC Bioinformatics Center
Maintainer: David Jimenez-Morales <davidjm@stanford.edu>
Description: R Package for the analysis of MoTrPAC datasets.
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# MotrpacBicQC 0.5.9 (2021-08-10)

* Adjustments for PASS1C-06
* Bug fixes affecting HUMAN phase processing

# MotrpacBicQC 0.5.8 (2021-08-06)

* New Metabolomics QC plots: number and proportion of named vs unnamed features identified
Expand Down
19 changes: 10 additions & 9 deletions R/metabolomics_qc.R
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,12 @@ validate_metabolomics <- function(input_results_folder,
phase <- validate_phase(input_results_folder)
tissue_code <- validate_tissue(input_results_folder)
batch_folder <- validate_batch(input_results_folder)

if( !is.null(dmaqc_phase2validate) ){
phase2check <- dmaqc_phase2validate
}else{
phase2check <- phase
}

# issue_count-----
ic <- 0
Expand All @@ -574,10 +580,10 @@ validate_metabolomics <- function(input_results_folder,

input_results_folder <- normalizePath(input_results_folder)

input_folder_short <- regmatches(input_results_folder, regexpr("PASS.*PROCESSED_[0-9]{8}", input_results_folder))
input_folder_short <- regmatches(input_results_folder, regexpr("(HUMAN|PASS).*PROCESSED_[0-9]{8}", input_results_folder))
if(is_empty(input_folder_short)){
if(verbose) message("\nThe PROCESSED_YYYYMMDD folder full path is not correct. Example:")
if(verbose) message("/full/path/to/folder/PASS1A-06/T66/RPNEG/BATCH1_20190822/PROCESSED_202003")
if(verbose) message("/full/path/to/folder/PASS1A-06/T66/RPNEG/BATCH1_20190822/PROCESSED_20200302")
stop("Input folder not according to guidelines")
}

Expand Down Expand Up @@ -760,7 +766,7 @@ validate_metabolomics <- function(input_results_folder,

if(verbose) message("\n\n## QC Plots\n")

output_prefix <- paste0(cas, ".", tolower(phase), ".", tissue_code, ".",tolower(assay), ".", tolower(processfolder))
output_prefix <- paste0(cas, ".", tolower(phase2check), ".", tissue_code, ".",tolower(assay), ".", tolower(processfolder))

if(f_rmn & f_msn ){
r_m_n$id_type <- "named"
Expand Down Expand Up @@ -996,11 +1002,6 @@ validate_metabolomics <- function(input_results_folder,
if( is.na(ic_vl) ){
if(f_msn){
vl_results <- m_s_n$sample_id[which(m_s_n$sample_type == "Sample")]
if( !is.null(dmaqc_phase2validate) ){
phase2check <- dmaqc_phase2validate
}else{
phase2check <- phase
}
ic_vl <- check_viallabel_dmaqc(vl_submitted = vl_results,
tissue_code = tissue_code,
cas = cas,
Expand Down Expand Up @@ -1030,7 +1031,7 @@ validate_metabolomics <- function(input_results_folder,
if(verbose) message("\nTOTAL NUMBER OF ISSUES: ", total_issues,"\n")
if(full_report){
reports <- data.frame(cas = cas,
phase= phase,
phase= phase2check,
tissue = tissue_code,
t_name = t_name,
assay = assay,
Expand Down
2 changes: 1 addition & 1 deletion docs/404.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/LICENSE-text.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/articles/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/articles/other_functions.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="generator" content="pandoc">
<meta name="date" content="2021-08-06">
<meta name="date" content="2021-08-11">
<title>MotrpacBicQC: Other Functions</title>
<script src="other_functions_files/header-attrs-2.9/header-attrs.js"></script><script src="other_functions_files/jquery-1.11.3/jquery.min.js"></script><meta name="viewport" content="width=device-width, initial-scale=1">
<link href="other_functions_files/bootstrap-3.3.7/css/bootstrap.min.css" rel="stylesheet">
Expand Down Expand Up @@ -123,7 +123,7 @@ <h1 class="hasAnchor">

<p class="authors">
</p>
<p class="date"><span class="glyphicon glyphicon-calendar"></span> 2021-08-06</p>
<p class="date"><span class="glyphicon glyphicon-calendar"></span> 2021-08-11</p>



Expand Down
4 changes: 2 additions & 2 deletions docs/articles/qc_metabolomics.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="generator" content="pandoc">
<meta name="date" content="2021-08-06">
<meta name="date" content="2021-08-11">
<title>MotrpacBicQC: Metabolomics QC</title>
<script src="qc_metabolomics_files/header-attrs-2.9/header-attrs.js"></script><script src="qc_metabolomics_files/jquery-1.11.3/jquery.min.js"></script><meta name="viewport" content="width=device-width, initial-scale=1">
<link href="qc_metabolomics_files/bootstrap-3.3.7/css/bootstrap.min.css" rel="stylesheet">
Expand Down Expand Up @@ -191,7 +191,7 @@ <h1 class="hasAnchor">

<p class="authors">
</p>
<p class="date"><span class="glyphicon glyphicon-calendar"></span> 2021-08-06</p>
<p class="date"><span class="glyphicon glyphicon-calendar"></span> 2021-08-11</p>



Expand Down
4 changes: 2 additions & 2 deletions docs/articles/qc_proteomics.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="generator" content="pandoc">
<meta name="date" content="2021-08-06">
<meta name="date" content="2021-08-11">
<title>MotrpacBicQC: Proteomics QC</title>
<script src="qc_proteomics_files/header-attrs-2.9/header-attrs.js"></script><script src="qc_proteomics_files/jquery-1.11.3/jquery.min.js"></script><meta name="viewport" content="width=device-width, initial-scale=1">
<link href="qc_proteomics_files/bootstrap-3.3.7/css/bootstrap.min.css" rel="stylesheet">
Expand Down Expand Up @@ -191,7 +191,7 @@ <h1 class="hasAnchor">

<p class="authors">
</p>
<p class="date"><span class="glyphicon glyphicon-calendar"></span> 2021-08-06</p>
<p class="date"><span class="glyphicon glyphicon-calendar"></span> 2021-08-11</p>



Expand Down
2 changes: 1 addition & 1 deletion docs/authors.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion docs/news/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/notes_developers.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ articles:
other_functions: other_functions.html
qc_metabolomics: qc_metabolomics.html
qc_proteomics: qc_proteomics.html
last_built: 2021-08-06T23:18Z
last_built: 2021-08-11T17:35Z

2 changes: 1 addition & 1 deletion docs/reference/assay_abbr.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/assay_codes.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/assay_order.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/bic_animal_tissue_code.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/check_failedsamples.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/check_manifest_rawdata.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/check_metadata_metabolites.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/check_metadata_samples.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/check_ratio_proteomics.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/check_results.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/check_rii_proteomics.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/check_vial_metadata_proteomics.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/check_viallabel_dmaqc.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/combine_metabolomics_batch.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/filter_required_columns.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/get_and_validate_mdd.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/group_abbr.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/group_cols.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/load_metabolomics_batch.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 11df94d

Please sign in to comment.