Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #54

Merged
merged 11 commits into from
Nov 10, 2023
Merged

Update dependencies #54

merged 11 commits into from
Nov 10, 2023

Conversation

nicolerg
Copy link
Collaborator

@nicolerg nicolerg commented Nov 9, 2023

  • Remove "vignette is under construction" message
  • Add CODEOWNERS file
  • Use the development version of RCy3 until R-CMD-check will install a version of RCy3 that doesn't depend on uchardet, which was removed from CRAN
  • Install orphaned plotrix package from GitHub instead of CRAN to resolve R-CMD check warning

@nicolerg nicolerg changed the title Update message in vignette Maintenance Nov 9, 2023
nicolerg/ssGSEA2
nicolerg/ssGSEA2,
cytoscape/RCy3,
plotrix/plotrix
Copy link
Collaborator Author

@nicolerg nicolerg Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Download plotrix from GitHub to avoid R-CMD check warning Requires (indirectly) orphaned package: ‘plotrix’. CRAN has marked plotrix as orphaned.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotrix is a dependency for mutoss, which is a dependency for metap

@@ -89,7 +90,9 @@ Remotes:
MoTrPAC/MotrpacRatTraining6moData,
MoTrPAC/MotrpacBicQC,
YuLab-SMU/ggtree,
nicolerg/ssGSEA2
nicolerg/ssGSEA2,
cytoscape/RCy3,
Copy link
Collaborator Author

@nicolerg nicolerg Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Download development version of RCy3 to avoid R-CMD check error:

  * deps::.: Can't install dependency RCy3 (>= 2.22.1)
  * RCy3: Can't install dependency uchardet
  * uchardet: Can't find package called uchardet.

Oddly, RCy3 v2.22.1 has already removed uchardet as a dependency, and I don't get an error installing RCy3 locally, so I'm not sure why this isn't working for the GitHub Actions check. This is a temporary fix that should be reverted once the GitHub Actions check can pass.

@nicolerg nicolerg changed the title Maintenance Update dependencies Nov 10, 2023
@nicolerg nicolerg merged commit 0f38357 into main Nov 10, 2023
1 check passed
@nicolerg nicolerg deleted the update-vignette branch November 10, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant