forked from ENCODE-DCC/caper
-
Notifications
You must be signed in to change notification settings - Fork 0
v3.0.0 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mihirsamdarshi
wants to merge
44
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
v3.0.0 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bfd0f9 to
8713ca2
Compare
3a1b418 to
0137aaf
Compare
…` argument to `group_cromwell`
- Add type hints to all methods and attributes - Improve docstrings with more detailed descriptions - Enhance error handling in the read method - Add proper return type annotations - Fix typo in interval_update_heartbeat parameter - Convert heartbeat_file to string path - Check file existence before reading - Use more specific exception handling
- restrict supported python versions to 3.10 through 3.14 - update argcomplete from 3.6.2 to 3.6.3 - update awscli from 1.41.9 to 1.44.4 - update boto3 from 1.39.9 to 1.42.14 - include all scripts in package-data instead of only gcp_caper_server - add ruff configuration for linting and formatting - set line-length to 96 characters - enable all ruff rules except explicitly ignored ones
Added '*.code-workspace' to .gitignore to prevent committing VS Code workspace configuration files.
Adds explicit setting of 'auth' to 'service-account' in the batch configuration when a GCP service account key JSON is provided. Ensures correct authentication method is used for Google Cloud Platform workflows.
- Add comprehensive type hints throughout the module - Introduce new `_CallContext` dataclass for internal tracking - Enhance function signatures with proper return types - Improve docstrings for all public methods - Add error handling for edge cases in parsing functions - Update class attributes with type information
- Replace legacy `MutableMapping` import with direct `collections.abc` - Introduce new type variables `T`, `U`, and `W` for better type coverage - Add overloads to `flatten_dict()` for optional reducer support - Extend type hints across all function signatures - Standardize docstring formatting throughout the module - Clarify argument descriptions in function documentation
- Restructure argument parsing functions into smaller, focused methods - Add type hints and docstrings to improve code clarity - Separate localization arguments into dedicated function - Update enum definition with descriptive docstring and uppercase naming - Maintain existing functionality while making code more maintainable
- Add type hints throughout the module - Replace string formatting with f-strings - Improve error handling for HTTP and connection errors - Increase default timeout to 300 seconds - Add module docstring - Update function signatures with proper typing - Improve UUID validation logic - Enhance wildcard detection for strings and iterables
- Add module docstring for clarity - Restructure WorkflowStatusTransition with detailed docstrings - Improve type hints and formatting throughout - Consolidate regex patterns using WORKFLOW_UUID_REGEX constant - Enhance logging format for consistency
- Replace string formatting in error messages with f-strings - Add type hints to functions and methods - Use named variables for error messages - Improve docstrings with type information - Add noqa comments where necessary - Simplify conditional logic in subcmd_hpc - Standardize error message formatting across the file
- Add module-level docstring - Use TYPE_CHECKING for optional imports - Improve parameter type hints - Add class-level docstrings
- Change default GCS root from `gs://encode-test-caper` to `gs://motrpac-test-caper` - Remove default value for `--gcp-prj` option to enforce explicit project specification - Add validation for GCS root URI format - Support `GOOGLE_CLOUD_PROJECT` environment variable as alternative to `--gcp-prj` - Update resource metadata path construction to use the configured GCS root - Improve code formatting and type hints for better clarity
- Add return type annotation to functions in test files for better code clarity - Update pytest parameter names to use tuples instead of variables for cleaner test definitions
- Update Java (>= 11) to Java >= 17 - Update Python from >=3.6 to >=3.12 - Replace pip install with uv/uvx for installation - Update troubleshooting link to DETAILS.md - Clarify MoTrPAC fork details in Introduction`
- Remove legacy JSON key file authentication in favor of VM-attached service accounts - Simplify positional arguments to require only instance name, project ID, and output directory - Add new optional argument for Batch worker service account - Update default Ubuntu image to 22.04 Jammy from 20.04 Focal - Improve documentation with clearer examples and authentication options - Change error messages from "Wrong parameter" to "Unknown parameter" - Update username description to clarify it's for SSH only - Add recommended authentication method example first
- Add GitHub Actions workflow file for test execution - Configure unit tests to run on Python 3.12, 3.13, and 3.14 - Add GCP integration tests requiring maintainer approval - Implement test splitting with environment-specific execution - Include proper cleanup for GCS artifacts after tests
- for better OmicsPipelines integration
- Add `gcp_network` and `gcp_subnetwork` parameters to backend configuration - Support custom subnet mode VPCs in GCP Batch backend - Update parameter documentation for new networking options - Implement VPC configuration in backend initialization
- Add gcp_dockerhub_mirror and gcp_dockerhub_mirror_address parameters - Enable Docker Hub mirroring through Google Artifact Registry by default - Allow customization of the mirror address with a configurable option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--gcp-compute-service-accountto specify service accounts for Batch compute instances.