Connects to #355. Connects to #356. Homepage UI improvements. #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…folder content is rendered
This reverts commit 80509c9.
This was
linked to
issues
Jul 3, 2024
jyu-sm
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
The changes in the dev are verified and look good.
The only comment is that if it's possible/preferable to change the absolute path such as:
https://cdn.motrpac-data.org/assets/datahub/landing_page/media/background_video_molecules_221511488.mp4 to a relative one like the other media file paths in the code?
|
@jyu-sm That media file is hosted on a CDN (external to the Data Hub). How does a relative path work in this case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes:
lazyloadimages, along other adjustments to attempt in improving homepage loading performance.