Update pyproject.toml to fix issue #2286 #2288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug in oscrypto where the regex would fail to recognize the right version of SSL due to insufficient check on multiple digits. However the owner of the repo does not plan to make a new release soon due to time constraints. See -> wbond/oscrypto#78 This can be fixed by using a specific version from git pointing to the right commit. Hence this change in the pyproject.toml file.
|
We will be removing the dependency on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Pull Request
Fixed a bug in oscrypto where the regex would fail to recognize the right version of SSL due to insufficient check on multiple digits. However the owner of the repo does not plan to make a new release soon due to time constraints. See -> wbond/oscrypto#78
This can be fixed by using a specific version from git pointing to the right commit. Hence this change in the pyproject.toml file.
Checklist for PR
Tested on the Kali System mentioned in Issue #2286.
If this is not good enough for this change, I need to invest more time.
However this is an upstream fix in the lib itself and only changes the dependency to a specific commit.
Additional Comments (if any)
#2286