fix: Add platform compatibility for BUFFER_LENGTH (add ESP32) #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace undefined BUFFER_LENGTH with platform-specific definitions - Add support for ESP32/ESP8266 (uses I2C_BUFFER_LENGTH or 128 default) - Add support for Arduino AVR platforms (32 bytes) - Add support for Raspberry Pi Pico/RP2040 (256 bytes) - Add compile-time error for unsupported platforms - Resolves compilation error on ESP32 builds
… current ino format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements focused on code formatting consistency, cross-platform compatibility, and code style cleanup for the
LiquidCrystal_I2Clibrary. The main changes include the addition of formatting configuration files, updates to VSCode workspace settings, and a comprehensive refactor to consistently use Allman braces and improve buffer handling for multiple platforms.Formatting and Editor Configuration:
.clang-formatfile to enforce consistent C++ code style, including indentation, brace placement, and other formatting rules..vscode/settings.jsonto align editor settings with the new formatting standards and ensure consistent formatting for C/C++ files, with special handling for.cppand header files.Cross-platform Buffer Handling:
LiquidCrystal_I2C.cppto support ESP32, ESP8266, AVR, and RP2040 platforms, ensuring the correct I2C buffer length is used based on the target architecture.Code Style Consistency:
LiquidCrystal_I2C.cppto use Allman-style braces and improved code readability by reformatting function bodies and comments because there was no continous style.