Fix Analog Read not working #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Board and firmware folder for this pull request: |
DocMoebiuz
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
With FW version 3.0.0 analog read is not working anymore.
In this version a new deviceID for analog devices was introduced. This new analog device does not enable the PullUp's for the configured pins to get a linear read in.
During reading the config from flash the number of devices per type is calculated to define the array size for these devices. For devices with deprecated ID's also these one have to be considered. This was not implemented. So only new analog device types are considered, but as the connector does not support this type yet, the number of analog devices is always zero. While adding a device it's checked if the calculatd number get's exceeded. If so, no device gets added.
Fixes #356