-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-22366] Basic column lineage handling in consumer #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #155 +/- ##
===========================================
+ Coverage 93.17% 93.49% +0.31%
===========================================
Files 185 191 +6
Lines 4250 4459 +209
Branches 281 299 +18
===========================================
+ Hits 3960 4169 +209
- Misses 227 229 +2
+ Partials 63 61 -2 ☔ View full report in Codecov by Sentry. |
dolfinus
commented
Feb 18, 2025
tests/test_consumer/test_extractors/test_extractors_column_lineage.py
Outdated
Show resolved
Hide resolved
dolfinus
commented
Feb 18, 2025
tests/test_consumer/test_extractors/test_extractors_column_lineage.py
Outdated
Show resolved
Hide resolved
dolfinus
commented
Feb 18, 2025
tests/test_consumer/test_extractors/test_extractors_column_lineage.py
Outdated
Show resolved
Hide resolved
dolfinus
commented
Feb 18, 2025
dolfinus
commented
Feb 18, 2025
dolfinus
commented
Feb 18, 2025
dolfinus
commented
Feb 18, 2025
dolfinus
commented
Feb 18, 2025
LGTM. Unfortunately, cannot approve this PR as I'm the author :) |
IlyasDevelopment
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Depends on #153.
Implement basic column lineage handler in consumer.
There are 2 DTO classes:
ColumnLineageDTO
- describes tuple(operation, source_dataset, target_dataset)
.DatasetColumnRelationDTO
- describessource_column -> target_column (optional)
relations withinColumnLineageDTO
Extractor builds list of these
ColumnLineageDTO
for each operation, and then perform bulk insert. Table rows are immutable, usingON CONFLICT DO NOTHING
with few additional checks to reduce database IO.This lacks any tests, these should be added in next commits.
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)