Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-23122] Replace python-jose with pyjwt #179

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Dec 25, 2024

Change Summary

python-jose last release version was in 2021. Replace it with a modern library. This fixes several security issues.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Dec 25, 2024
@dolfinus dolfinus marked this pull request as ready for review December 25, 2024 10:00
@dolfinus dolfinus merged commit 6c570d9 into develop Dec 25, 2024
19 of 20 checks passed
@dolfinus dolfinus deleted the bugfix/DOP-23149 branch December 25, 2024 12:21
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (950b23b) to head (d7de39e).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@      Coverage Diff       @@
##   develop   #179   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants