Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-15023] Pass Run to CREATE_SPARK_SESSION_FUNCTION #38

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Apr 16, 2024

Change Summary

  • Pass Run object to CREATE_SPARK_SESSION_FUNCTION, and use it as a source for Spark Session appName
  • Streamline Handler object - instead of creating one-time attributes reader, writer and spark, create them only then needed
  • Move file format handling to FileTransferDTO

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Apr 16, 2024
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from 78e67c4 to e20d425 Compare April 16, 2024 10:54
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from e20d425 to 6851dd9 Compare April 16, 2024 11:00
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from 6851dd9 to efbded7 Compare April 16, 2024 11:05
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from efbded7 to f25bc99 Compare April 16, 2024 11:32
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from f25bc99 to 33c59db Compare April 16, 2024 11:33
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from 33c59db to 07d6c48 Compare April 19, 2024 13:56
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from 07d6c48 to ae0b3c6 Compare April 19, 2024 14:05
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from ae0b3c6 to fed3c49 Compare April 19, 2024 18:27
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 97.20280% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.44%. Comparing base (67a17b0) to head (0522b25).

Files Patch % Lines
syncmaster/dto/transfers.py 91.66% 1 Missing and 2 partials ⚠️
syncmaster/worker/transfer.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #38      +/-   ##
===========================================
+ Coverage    91.84%   92.44%   +0.59%     
===========================================
  Files           83       84       +1     
  Lines         2440     2421      -19     
  Branches       308      306       -2     
===========================================
- Hits          2241     2238       -3     
+ Misses         140      128      -12     
+ Partials        59       55       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus marked this pull request as ready for review April 22, 2024 13:00
@dolfinus dolfinus merged commit e27ad39 into develop Apr 22, 2024
17 checks passed
@dolfinus dolfinus deleted the feature/DOP-15023 branch April 22, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants