[Fix]correct the error in docs #340
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero0307
requested review from
FangRun2,
Tarrei,
flesher0813,
hek14,
mag1c-h and
ygwpz
as code owners
flesher0813
reviewed
Nov 5, 2025
| ## Features Overview | ||
|
|
||
| UCM supports two key features: **Prefix Cache** and **GSA Sparsity**. | ||
| UCM supports two key features: **Prefix Cache** and **Sparse-attention**. |
Contributor
There was a problem hiding this comment.
Do we need change feature name below?
There was a problem hiding this comment.
GSA is just one algorithm among sparse attention methods. GSA can only serve as an example of this feature.
| # For GPU devices, use the following command: | ||
| export CUDA_VISIBLE_DEVICES=0 | ||
| # For NPU devices, use the following command: | ||
| export ASCEND_RT_VISIVLE_DEVEICES=0 |
Contributor
There was a problem hiding this comment.
Kind of weird putting setting commands of two different hardwares here, maybe we can follow what is done in Quickstart doc？Same in xpyd.md
flesher0813
reviewed
Nov 6, 2025
| ## Prerequisites | ||
| - UCM: Installed with reference to the Installation documentation. | ||
| - Hardware: At least 4 GPUs (At least 2 GPUs for prefiller + 2 for decoder in 2d2p setup) | ||
| - Hardware: At least 4 GPUs (At least 2 GPUs for prefiller + 2 for decoder in 2d2p setup or 2 NPUs for prefiller + 2 for decoder in 2d2p setup) |
Contributor
There was a problem hiding this comment.
It does not match for 'At least 4 GPUs' and 'or 2 NPUs for prefiller + 2 for decoder in 2d2p setup'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Corrtct some errors in docs
Modifications
Corrtct some errors in docs
Test
Corrtct some errors in docs