-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting PR #9
Conversation
***Refactor code for better readability*** ***Update error handling in API calls***
***Add error handling for null values*** ***Update variable names for clarity*** ***Fix bug in conditional statement*** ***Update comments for better documentation*** ***Remove unused imports*** ***Optimize database query*** ***Update README with new instructions*** ***Fix formatting issues*** ***Add unit tests for new feature
…d/betty_fixer into features.lintingPEP8
…m betty_fixer module
@Younis-Ahmed can you document the commands you are using to run the test cases on the errors_log folder and the pylint. |
@be-great Thanks 🙏 Here you go! pylint "$file" --reports=y -f parseable >> $outputfile Please note that this is code snippet is part of a bash script i made to integrate into my workflow, it replaces the need to use The rationale behind this workflow is to log everything that happens within the linting scope, with the integration of my PR the github action will reject merging all code that is not conforming to PEP8 rules. Leaving holes in the project memory. CI workflowstateDiagram-v2
[*] --> NewPR
NewPR --> linting_action: triggered
linting_action --> isValid: pylint and pycodestyle validation
isValid --> yes: Merge
isValid --> no: exit 1
no --> Terminated
yes --> Terminated
Terminated--> [*]
If you want this level of logs records in your project let me know and i will add the script <-- This can be enforced at the
|
Okay, I will test it, and notify you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merged
Formatting PR Summary
This PR provides several fixes and improvements:
errors_log
directory to track pylint linting reports. This will help us maintain a high-quality codebase and quickly identify any areas that need improvement. added the directory and pylintrc to MANIFEST.in to exclude. upon compilation for pypibetty_fixer
andbetty_handler
modules. #7: Removed thebetty_handler.py
module. The function inside this module was a duplication.pylint disabled
for certain errors and can be found by parsing the codebase withpylint
inside the package For future contributions.pylint && pycodestyle
linter upon push or PR, Also added Python matrix<-- [3.8, 3.9, 3.10]
Major changes Made
errors_log
.betty_handler.py
module.betty_fixer
andbetty_handler
modules. #7 and partially fixes Codebase Formatting and Test Suite Proposal #5